Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate initial_value="variable" in 2.1 #322

Open
MichaelClerx opened this issue Apr 21, 2020 · 2 comments
Open

Deprecate initial_value="variable" in 2.1 #322

MichaelClerx opened this issue Apr 21, 2020 · 2 comments
Labels
normative Pertaining to the normative specification

Comments

@MichaelClerx
Copy link
Contributor

After discussion in #56 I think we decided to deprecate it but then forgot?

Either way, I'd like it officially discouraged starting from 2.1 :D

@MichaelClerx MichaelClerx added the normative Pertaining to the normative specification label Apr 21, 2020
@kerimoyle
Copy link
Collaborator

I've reread this thread again and I still don't quite understand how to best construct a model without it. Here is my model:

Component which does the stuff (deep somewhere inside an encapsulation):

x = dx/dt
x(t=0) = x0 <- equivalent variable to one at the top level??

or

x = dx/dt
x(t=0) = 1 <- hardcoded deep inside the model??

How do I keep parameters/initial values separate from the model mathematics if I can't set the initial value to a variable?

@MichaelClerx
Copy link
Contributor Author

component_deep_within
    var x interface="whatever"
    maths
        dx/dt = f(...)

component_with_all_the_initial_values
    var x interface="..." initial_value ="1"

connection:
     x to x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
normative Pertaining to the normative specification
Projects
None yet
Development

No branches or pull requests

2 participants