Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded Docker image from v3 e2e upgrade test #3947

Open
rootulp opened this issue Oct 7, 2024 · 1 comment
Open

Remove hardcoded Docker image from v3 e2e upgrade test #3947

rootulp opened this issue Oct 7, 2024 · 1 comment
Labels
needs:triage testing items that are strictly related to adding or extending test coverage

Comments

@rootulp
Copy link
Collaborator

rootulp commented Oct 7, 2024

Context

The v3 e2e test needs a slightly modified txsim. Since those modifications were introduced in the same PR as the test, we had to use "pr-3910" as the version for txsim in the test.

Proposal

Remove the "pr-3910" version from the v3 e2e upgrade test

Originally posted by @evan-forbes in #3910 (comment)

@rootulp
Copy link
Collaborator Author

rootulp commented Oct 9, 2024

Note there's an extra complication in addressing this issue. The v3 e2e test needs to override the upgrade height delay. We do that via built tags. The docker image used in the test needs to have the upgrade height overridden to 1. So we need to figure out a mechanism to create new Docker images for celestia-app that overrides the upgrade height to 1.

@rootulp rootulp changed the title Remove pr-3910 from v3 upgrade test Remove hardcoded Docker image from v3 e2e upgrade test Oct 9, 2024
@rootulp rootulp added the testing items that are strictly related to adding or extending test coverage label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:triage testing items that are strictly related to adding or extending test coverage
Projects
None yet
Development

No branches or pull requests

1 participant