Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor TestApp #2535

Open
evan-forbes opened this issue Sep 18, 2023 · 1 comment
Open

Refactor TestApp #2535

evan-forbes opened this issue Sep 18, 2023 · 1 comment
Labels
nice to have item is not blocking or required. priority:low optional label to track the relative priority of planned items refactor optional label for items that are related to implementation work and do not change functionality testapp directly relevant to testapp usage testing items that are strictly related to adding or extending test coverage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc

Comments

@evan-forbes
Copy link
Member

evan-forbes commented Sep 18, 2023 •
edited
Loading

iirc, we essentially just took our TestApp from the simapp in the sdk. The api for using this test application could be greatly improved to provide test writers with fine grained and each control over the ABCI. This should include easily spinning up a custom application, creating new blocks, execution transactions, querying state, a mock mempool, and even manual state manipulation. The overall goal should be to create a tool that allows us to replace many of our integration tests, which we have used mainly because we don't have a good test app api

blocking #2533
@evan-forbes evan-forbes added testing items that are strictly related to adding or extending test coverage refactor optional label for items that are related to implementation work and do not change functionality testapp directly relevant to testapp usage labels Sep 18, 2023
@evan-forbes evan-forbes mentioned this issue Oct 6, 2023
Merged
@evan-forbes
Copy link
Member Author

either with testapp or even with testnode, we might want to consider using libraries such as https://github.com/informalsystems/CometMock

@rootulp rootulp added the WS: V2 ✌️ lemongrass hardfork related label Mar 7, 2024
@rootulp rootulp added this to the v2 milestone Mar 7, 2024
@rootulp rootulp added the nice to have item is not blocking or required. label Apr 1, 2024
@rootulp rootulp added needs:triage priority:low optional label to track the relative priority of planned items and removed needs:triage labels Apr 9, 2024
@evan-forbes evan-forbes added the WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc label Jun 3, 2024
@ninabarbakadze ninabarbakadze mentioned this issue Jun 10, 2024
Merged
@rootulp rootulp removed this from the v2 milestone Jun 24, 2024
@rootulp rootulp removed the WS: V2 ✌️ lemongrass hardfork related label Jun 24, 2024
@evan-forbes evan-forbes mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have item is not blocking or required. priority:low optional label to track the relative priority of planned items refactor optional label for items that are related to implementation work and do not change functionality testapp directly relevant to testapp usage testing items that are strictly related to adding or extending test coverage WS: Maintenance 🔧 includes bugs, refactors, flakes, and tech debt etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rootulp @evan-forbes