Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing annotations in Kombu (PEP 484) #1485

Closed
atombrella opened this issue Jan 30, 2022 · 9 comments
Closed

Use typing annotations in Kombu (PEP 484) #1485

atombrella opened this issue Jan 30, 2022 · 9 comments
Assignees
Milestone

Comments

@atombrella
Copy link
Contributor

atombrella commented Jan 30, 2022

Please see celery/celery#7258 for more detail.

I have a branch where I did some work with com2ann, and not much else (except importing from typing). It's a lot of work to annotate an entire code base, but may help finding potential bugs, and increase readability.
https://github.com/atombrella/kombu/tree/type_annotations

@open-collective-bot
Copy link

Hey @atombrella 👋,
Thank you for opening an issue. We will get back to you as soon as we can.
Also, check out our Open Collective and consider backing us - every little helps!

We also offer priority support for our sponsors.
If you require immediate assistance please consider sponsoring us.

@auvipy
Copy link
Member

auvipy commented Jan 30, 2022

we prefer progressive typing.

@atombrella
Copy link
Contributor Author

we prefer progressive typing.

So everything at once, rather than adding them incrementally? I'm not really sure I follow what you mean.

@auvipy
Copy link
Member

auvipy commented Jan 30, 2022

I meant incremental by telling progressive :)

@atombrella
Copy link
Contributor Author

I meant incremental by telling progressive :)

Good 👍 It's also the approach that Certbot followed (I helped with the Apache module).

@auvipy
Copy link
Member

auvipy commented Jan 31, 2022

I am sorry for not providing 100% correct english, it's not my mother tongue

@auvipy
Copy link
Member

auvipy commented Jan 31, 2022

small incremental/gradual changes are better. you don't have to worry about full code base. I can also take some stub of that.

@atombrella
Copy link
Contributor Author

I am sorry for not providing 100% correct english, it's not my mother tongue

It's not mine either, so no worries :)

small incremental/gradual changes are better. you don't have to worry about full code base. I can also take some stub of that.

It takes a long time to add them, so that's a good suggestion.

@auvipy auvipy self-assigned this Jan 31, 2022
@auvipy
Copy link
Member

auvipy commented Jun 29, 2022

closing in favor of #1511

@auvipy auvipy closed this as completed Jun 29, 2022
@auvipy auvipy added this to the 5.3 milestone Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants