-
-
Notifications
You must be signed in to change notification settings - Fork 945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use typing annotations in Kombu (PEP 484) #1485
Comments
Hey @atombrella 👋, We also offer priority support for our sponsors. |
we prefer progressive typing. |
So everything at once, rather than adding them incrementally? I'm not really sure I follow what you mean. |
I meant incremental by telling progressive :) |
Good 👍 It's also the approach that Certbot followed (I helped with the Apache module). |
I am sorry for not providing 100% correct english, it's not my mother tongue |
small incremental/gradual changes are better. you don't have to worry about full code base. I can also take some stub of that. |
It's not mine either, so no worries :)
It takes a long time to add them, so that's a good suggestion. |
closing in favor of #1511 |
Please see celery/celery#7258 for more detail.
I have a branch where I did some work with
com2ann
, and not much else (except importing fromtyping
). It's a lot of work to annotate an entire code base, but may help finding potential bugs, and increase readability.https://github.com/atombrella/kombu/tree/type_annotations
The text was updated successfully, but these errors were encountered: