feat: simplify production release reverts #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the Production Terraform workflows so that a release can more easily be reverted. Now all that will be required to revert a failed release is to revert the Release Please PR. The way this works is as follows: 1. When a PR that updates `version.txt` is opened, the TF plan workflow will check if it's a Release Please branch. If yes, the branch is used to perform the TF plan. Otherwise the tag specified in `version.txt` is used for the TF plan operation. 2. On merge of a PR with a `version.txt` change, the TF apply workflow will wait for the git tag it specifies to exist. For a normal release flow, this will be once the `release_generator` workflow finished. For a revert PR, the tag will already exist. Additionally, the code checkout step has been removed from the `update-lambda-function-image` job as it is not needed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the Production Terraform workflows so that a release can more easily be reverted. Now all that will be required to rollback a failed release is to revert the Release Please PR.
The way this works is as follows:
When a PR that updates
version.txtis opened, the TF plan workflow will check if it's a Release Please branch. If yes, the branch is used to perform the TF plan. Otherwise it is assumed to be a revert PR and the tag specified inversion.txtis used for the TF plan operation.On merge of a PR with a
version.txtchange, the TF apply workflow will wait for the git tag it specifies to exist. For a normal release flow, this will be once therelease_generatorworkflow finished. For a revert PR, the tag will already exist.Additionally, the code checkout step has been removed from the
update-lambda-function-imagejob as it is not needed.Related