Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: get the CRF suggestions back D: #63

Closed
L0Lock opened this issue Sep 15, 2020 · 2 comments
Closed

Feature Request: get the CRF suggestions back D: #63

L0Lock opened this issue Sep 15, 2020 · 2 comments

Comments

@L0Lock
Copy link

L0Lock commented Sep 15, 2020

I see in this commit you added more CRF values. Which is neat!

But I also see you removed the little resolutions parentheses. IMHO these were neat as well. I mean, even though I know how to choose the proper CRF values, I'm always a little lazy concerned about the time I spend prevaricating instead of hitting the Convert button.

On a more serious tone, I think these indications are a good thing for anyone a bit new to ffmpeg or just in need for tools that are quick and easy to understand.

So... Maybe it would be nice to add them back ?

@cdgriffith
Copy link
Owner

cdgriffith commented Sep 15, 2020

The problem with them was they weren't especially clear, and with more CRFs didn't want to have too much confusion, but I think you are right. I am adding them back with a bit more details in the tool tip.

Edit: That, and at least one person found them useful, so probably more have as well. So thanks for letting me know!

@cdgriffith
Copy link
Owner

Added again in https://github.com/cdgriffith/FastFlix/releases/tag/2.6.1, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants