From 7631a3426d961f931bd2cc14edd7cf960371328e Mon Sep 17 00:00:00 2001
From: Chris Griffith <chris@cdgriffith.com>
Date: Sat, 22 Aug 2020 21:38:12 -0500
Subject: [PATCH] Version 2.3.4 (#48)

* Fixing audio downmixing only taking last downmixing setting
---
 CHANGES                          | 5 +++++
 fastflix/plugins/common/audio.py | 3 +--
 fastflix/version.py              | 2 +-
 fastflix/widgets/about.py        | 3 ---
 pyproject.toml                   | 2 +-
 5 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/CHANGES b/CHANGES
index e22adc6e..64245ff0 100644
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,11 @@
 Changelog
 ---------
 
+Version 2.3.4
+~~~~~~~~~~~~~
+
+* Fixing audio downmixing only taking for last downmixing setting
+
 Version 2.3.3
 ~~~~~~~~~~~~~
 
diff --git a/fastflix/plugins/common/audio.py b/fastflix/plugins/common/audio.py
index 58c451d3..ddcc5c42 100644
--- a/fastflix/plugins/common/audio.py
+++ b/fastflix/plugins/common/audio.py
@@ -5,14 +5,13 @@
 def build_audio(audio_tracks, audio_file_index=0):
     command_list = []
     for track in audio_tracks:
-        downmix = f"-ac {track.downmix}" if track.downmix > 0 else ""
+        downmix = f"-ac:{track.outdex} {track.downmix}" if track.downmix > 0 else ""
         command_list.append(
             f"-map {audio_file_index}:{track.index} "
             f'-metadata:s:{track.outdex} title="{track.title}" '
             f'-metadata:s:{track.outdex} handler="{track.title}"'
         )
         if track.conversion.codec == "none":
-            # command_list.append(f"-c:a:{track.outdex-1} copy")
             command_list.append(f"-c:{track.outdex} copy")
         elif "conversion" in track:
             command_list.append(
diff --git a/fastflix/version.py b/fastflix/version.py
index ffa9c523..a9dbddfa 100644
--- a/fastflix/version.py
+++ b/fastflix/version.py
@@ -1,4 +1,4 @@
 #!/usr/bin/env python
 # -*- coding: utf-8 -*-
-__version__ = "2.3.3"
+__version__ = "2.3.4"
 __author__ = "Chris Griffith"
diff --git a/fastflix/widgets/about.py b/fastflix/widgets/about.py
index 829ea5e8..10a21af2 100644
--- a/fastflix/widgets/about.py
+++ b/fastflix/widgets/about.py
@@ -12,9 +12,6 @@
 
 
 class About(QtWidgets.QWidget):
-
-    # TODO add all licenses
-
     def __init__(self, parent=None):
         super(About, self).__init__(parent)
         layout = QtWidgets.QGridLayout()
diff --git a/pyproject.toml b/pyproject.toml
index 9a49a7e6..41298fc5 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "fastflix"
-version = "2.3.3"
+version = "2.3.4"
 description = "Easy to use video encoder GUI wrapper"
 authors = ["Chris Griffith <chris@cdgriffith.com>"]
 license = "MIT"