Improve performance of get_corrected_data #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndevenish
approved these changes
Sep 16, 2019
rjgildea
requested changes
Sep 16, 2019
graeme-winter
approved these changes
Sep 17, 2019
Anthchirp
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small change to improve performance of get_corrected_data.
If not external gain map is set then the gain map is populated from the detector panel gain value. This is not very efficient, especially if the gain is 1.0 and the pedestal is 0.0.
This pull request implements a change to get_gain and get_pedestal which means that if the detector panel gain is 1.0 then an empty array is returned from get_gain and is pedestal is 0.0 an empty array is returned from get_pedestal. This results in a large improvement in performance during integration.