New visitor implementation #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To fix #74 - NXgroup.visititems() does not follow soft links but probably it should, certainly this is a known issue on the h5py lists. Added new implementation local_visit which behaves as expected. Also found that saturation_value missing so worked around.
rjgildea
reviewed
Aug 28, 2019
format/nexus.py
Outdated
| @@ -150,6 +150,18 @@ def __call__(self, dset): | |||
| ) | |||
|
|
|||
|
|
|||
| def local_visit(nxfile, visitor): | |||
| """ | |||
There was a problem hiding this comment.
Could this be made a google-style docstring (as recommended by the DIALS contributing guide)
Write docstrings. We have a mix of styles at the moment, but new docstrings should try to follow Google-style - it has a good balance between clarity and length.
|
Probably a good idea to add a towncrier newsfragment for this (I guess this is a "bug"). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #74 -
NXgroup.visititems()does not follow soft links but probably it should, certainly this is a known
issue on the h5py lists. Added new implementation
local_visitwhich behavesas expected. Also found that
saturation_valuemissing so worked around. Following up with SLS on that one.