Remove putative_imgCIF_HDF5_mapping/X4_wide_M1S4_1.nxs #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was broken by #303, however according to #321 (comment) this test is not relevant as the file in question never properly matched the NXmx gold standard. Fixes #321
Codecov Report
@@ Coverage Diff @@
## main #327 +/- ##
=======================================
Coverage 46.74% 46.74%
=======================================
Files 233 233
Lines 19221 19221
Branches 2764 2764
=======================================
Hits 8985 8985
Misses 9739 9739
Partials 497 497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was broken by #303, however according to #321 (comment)
this test is not relevant as the file in question never properly matched the NXmx gold standard.
Fixes #321
The dials/latest build at DLS has been broken since this test has been failing - hence remove the offending dataset from the test as discussed in #321