Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cast to numpy.string_ for comparison #190

Merged
merged 2 commits into from
Aug 5, 2020
Merged

Cast to numpy.string_ for comparison #190

merged 2 commits into from
Aug 5, 2020

Conversation

noemifrisina
Copy link

No description provided.

graeme-winter
graeme-winter approved these changes Jul 9, 2020
View reviewed changes
Copy link
Collaborator

@graeme-winter graeme-winter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it is somewhat ill defined whether strings in HDF5 should be str or numpy.string_ this makes a lot of sense, thank you - approved modulo tests passing: the online checks seem happy

I'll also add a newsfragment

@noemifrisina noemifrisina merged commit 1709663 into master Aug 5, 2020
@noemifrisina noemifrisina deleted the unit-numpy-string branch August 5, 2020 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graeme-winter graeme-winter graeme-winter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noemifrisina @graeme-winter