Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace d3d10.dll/dxgi.dll absolute path with relative #34

Closed
vlad54rus opened this issue Jan 7, 2024 · 5 comments · Fixed by #35
Closed

Replace d3d10.dll/dxgi.dll absolute path with relative #34

vlad54rus opened this issue Jan 7, 2024 · 5 comments · Fixed by #35

Comments

@vlad54rus
Copy link

CryRenderD3D10.dll loads d3d10.dll and dxgi.dll directly from C:\Windows\System32 which causes problems when using some dll wrappers such as DXVK (doitsujin/dxvk#551 (comment)).

@ccomrade
Copy link
Owner

ccomrade commented Jan 7, 2024

This is strange because CryRenderD3D10.dll has both d3d10.dll and dxgi.dll as its dependencies (dxgi.dll indirectly via d3d10.dll):

image

However, it also loads them explicitly (LoadLibraryW) from C:\Windows\System32 (GetSystemDirectoryW) during startup. Any idea what could be the reason for this weird behavior? CryRenderD3D9.dll doesn't do that with its DirectX DLLs.

@vlad54rus
Copy link
Author

Some developers do that, no idea why. But Crysis Warhead doesn't have such behavior.
I'd suggest removing GetSystemDirectoryW related code and replacing it with just LoadLibraryW("d3d10.dll") and LoadLibraryW("dxgi.dll").

@ccomrade
Copy link
Owner

ccomrade commented Jan 8, 2024

Implemented. Can you test that it works with DXVK now? Here are the EXEs. Or you can take those big ones from CI/CD artifacts. I should finally implement CI/CD builds with VS2005 compiler to automatically build small EXEs as well.

c1-launcher-v5-build.zip

@vlad54rus
Copy link
Author

Works great, thank you.

@ccomrade
Copy link
Owner

ccomrade commented Jan 9, 2024

No problem. Thanks for the test and for reporting the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants