Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player inventory does not update when interacting with terminal-less pocket computer #915

Closed
MAGGen-hub opened this issue Aug 31, 2021 · 3 comments
Labels
area-Minecraft This affects CC's Minecraft-specific content. bug A problem or unexpected behaviour with the mod.
Milestone

Comments

@MAGGen-hub
Copy link
Contributor

Minecraft Version

1.16.x

Version

Future 1.99.1

Details

When you open poket computer with no terminal and then pick up an item from ground - you can see it in player slots only after closing computer.
Here is a video:
P.S. (if item is new you can't see it to (i mean if I use non countable item in video i dot the same result))

2021-09-01.02-47-19.mp4
@MAGGen-hub MAGGen-hub added the bug A problem or unexpected behaviour with the mod. label Aug 31, 2021
@Lupus590
Copy link
Contributor

Could it be this feature? #861

@MAGGen-hub
Copy link
Contributor Author

I don't think so. For some reason when ps is open picked up items won't be rendered... It's strange case when you use other guis (work bench) there is no such problem. Oh! I need to say that this problem appears when any terminals is open (even with gui). Strange... I need to dig deeper, case I saw this problem in other mods. May be it's just Screen.java problem?

@SquidDev SquidDev added the area-Minecraft This affects CC's Minecraft-specific content. label Sep 1, 2021
@SquidDev SquidDev changed the title Open poket pc with no gui bug [pick up items issue] Player inventory does not update when interacting with terminal-less pocket computer Sep 1, 2021
@SquidDev
Copy link
Member

SquidDev commented Sep 1, 2021

Worth noting that this happens with any computer GUI (and amusingly the lectern in vanilla MC).

It's just more obvious in this case as the hotbar is more visible. I suspect the fix here is that we add the player's hotbar slots to the base container, which will force them to be synced when the change.

@SquidDev SquidDev added this to the 1.99.0 milestone Sep 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. bug A problem or unexpected behaviour with the mod.
Projects
None yet
Development

No branches or pull requests

3 participants