Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cauldron should be fluid_storage peripheral #1890

Open
tonitch opened this issue Jul 3, 2024 · 3 comments
Open

Cauldron should be fluid_storage peripheral #1890

tonitch opened this issue Jul 3, 2024 · 3 comments
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.

Comments

@tonitch
Copy link

tonitch commented Jul 3, 2024

Useful information to include:

  • Explanation of how the feature/change should work.
  • Some rationale/use case for a feature. My general approach to designing new features is to ask yourself "what issue are we trying to solve" and then "is this the best way to solve this issue?".

I might be wrong, but it seems like cauldron are not using fluid_storage. This would be handy.

Since there is possibility to produce lava in a cauldron, an excellent use case for this interface would be to make an automated lava farm that would power up turtles and the network would use networking cable.

I haven't tested that, but I suppose almost everything is already set. We just have to let the cauldron be fluid_peripheral.

@tonitch tonitch added the enhancement An extension of a feature or a new feature. label Jul 3, 2024
@zyxkad
Copy link
Contributor

zyxkad commented Jul 3, 2024

The reason that cauldron is not fluid_storage is because forge did not make it implement the FluidHandler capability

@tonitch
Copy link
Author

tonitch commented Jul 3, 2024

Do you think it could be fixed on cc:t 's side or maybe this should be an issue for forge?

@SquidDev
Copy link
Member

SquidDev commented Jul 3, 2024

No, no. This is 100% a bug on CC:T's side.

So for some history/context here, inventories and fluid tanks used to only be available on block entities. However, some blocks (like caldrons and composters) don't have a block entity associated with them, but still can behave as an inventory/tank.

Older versions of Forge (anything before MC 1.20.4) didn't really handle this correctly (though Fabric does!), which is why cauldrons aren't available as peripherals. However, NeoForge does support this — the issue is that CC:T has not updated it's generic peripheral code to handle that. There are some wider issues that affect generic peripherals on recent versions of the game (see also #1817), so that whole system probably needs a rewrite.

As far as MC 1.20.1, this is unlikely to be fixed, at least not without special handling for cauldrons.

@SquidDev SquidDev added the area-Minecraft This affects CC's Minecraft-specific content. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-Minecraft This affects CC's Minecraft-specific content. enhancement An extension of a feature or a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants