Headers passed to ActiveStorageProvider don't make it to DirectUploadProvider

[CaptainLexington]

I've been passing a headers prop to ActiveStorageProvider, but the request to direct_upload doesn't have those headers. When I put a breakpoint in addHeaders in Upload.js, this.options.headers is undefined - but when I put that breakpoint in ActiveStorageProvider's render method in index.js, headers has the correct value when it's destructured on line 51 - it's just not passed down or used anywhere. Is this the desired behavior? The documentation is not clear.

[cbothner]

Thanks for opening this issue. You’re right that the documentation isn’t clear on this.

That was the desired behavior; headers was destructured in order not to pass it down. My thinking was that in a standard Rails app the ActiveStorage::DirectUploadsController doesn’t expect any custom headers, but that your model’s controllers often will. I don’t feel strongly, however, and I’m open to reconsidering, provided it doesn’t mess up the default case.

Can you provide a little more detail about your use case? Are you using a custom direct uploads controller? What headers are you hoping to pass through?

[CaptainLexington]

We're just trying to authenticate with our direct_uploads route. I'm not very familiar with ActiveStorage, but the back-end guy tells me that ActiveStorage usually depends on a CSRF token that's embedded when the page is rendered, but since we're using not using Rails for serving our SPA that token isn't available. We want to use our normal authentication token for this, but we're open to other strategies. What do other Rails/React users normally do?

[cbothner]

ActiveStorage does depend on the CSRF token, which @rails/activestorage (which this library uses) looks for (in a meta tag in the document head) and includes automatically.

Since you’re not using Rails to serve the SPA, I see why you’re looking for another way to authenticate the uploads. I think the approach you’re considering is reasonable, and probably how most in your situation will do it.

I’m going to test with my vanilla ActiveStorage setup just to make sure unnecessary headers won’t cause any problems, then I’ll change this library to pass the headers as you’ve suggested.

[cbothner]

Released as v0.8.0

[CaptainLexington]

Wow, thank you so much!