Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing directory entries in jcommander jar #430

Closed
dipak-pawar opened this issue Jan 31, 2018 · 5 comments
Closed

Missing directory entries in jcommander jar #430

dipak-pawar opened this issue Jan 31, 2018 · 5 comments

Comments

@dipak-pawar
Copy link

Jcommander Version

1.72
1.66

Description:

  • Run jar -tf jcommander-1.72.jar
  • All entries for directories are not packaged in the jar. This causes a problem while trying to get resources from classpath.
  • Latest released testng jar is bundled with com.beust:jcommander:jar:1.66. I have opened similar issue for TestNG yesterday Missing directory entries in testng jar testng-team/testng#1677
  • In particular this causes problem in Arquillian integration with testng. See issue#comment

Expected behavior

META-INF/
META-INF/MANIFEST.MF
com/
com/beust/
com/beust/jcommander/
com/beust/jcommander/ParametersDelegate.class
com/beust/jcommander/IStringConverterInstanceFactory.class
com/beust/jcommander/FuzzyMap$IKey.class
com/beust/jcommander/MissingCommandException.class
com/beust/jcommander/internal/
com/beust/jcommander/internal/Maps.class
...

Actual behavior

com/beust/jcommander/converters/BaseConverter.class
com/beust/jcommander/converters/BigDecimalConverter.class
com/beust/jcommander/converters/BooleanConverter.class
com/beust/jcommander/converters/CharArrayConverter.class
com/beust/jcommander/converters/CommaParameterSplitter.class
com/beust/jcommander/converters/DefaultListConverter.class
com/beust/jcommander/converters/DoubleConverter.class
com/beust/jcommander/converters/EnumConverter.class
com/beust/jcommander/converters/FileConverter.class
com/beust/jcommander/converters/FloatConverter.class
...

Test case sample

https://github.com/dipak-pawar/jcommander-classloading

@krmahadevan
Copy link

@dipak-pawar - Thanks. I guess the problem in both the issues is the build tool kobalt.

@cbeust - can you please help ?

@cbeust
Copy link
Owner

cbeust commented Feb 23, 2018

Should be fixed in JCommander 1.73.

@manovotn
Copy link

manovotn commented Apr 4, 2018

@cbeust Hi, is there any time estimation on when jcommander 1.73 gets released (and ultimately, when TestNG gets it and is released)?

@cbeust
Copy link
Owner

cbeust commented Apr 4, 2018

1.73 has been out for a while: http://jcenter.bintray.com/com/beust/jcommander/1.73/

@manovotn
Copy link

manovotn commented Apr 4, 2018

Hmm, I was checking just Maven Central, it's probably not synced there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants