Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For basic flow, output cognito_identity_oidc_access_token not populated #6

Open
kubevalet opened this issue Jun 19, 2024 · 1 comment

Comments

@kubevalet
Copy link

In the outputs section, I see:

  cognito_identity_oidc_access_token:
    description: "Cognito Identity OIDC Access Token"
    value: ${{ steps.output.outputs.oidc_token }}

So it's expecting to be populated from oidc_token ...

But, in the output step, I see:

 echo "cognito_oidc_access_token=$oidcAccessToken" >> "$GITHUB_OUTPUT"

shouldn't this be oidc_token?

fwiw ~ I reverted back to using catnekaise/cognito-idpool-basic-auth@alpha and am able to access the token via:

${{ steps.web_id_token.outputs.cognito_identity_oidc_access_token }}
@djonser
Copy link
Member

djonser commented Jun 20, 2024

@kubevalet you are correct, I referenced the incorrect variable to output the OIDC token. Nice to see someone uses the feature.

Do you want to open a PR or should I go ahead and fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants