infinite loop with latest libstd++

[kirkshoop]

This bug causes std::uncaught_exception() to always return true once a std::exception_ptr has been passed to std::rethrow_exception()
Bug 62258 - uncaught_exception() equals to `true' after rethrow_exception()

The issue is that this line in Catch causes an early return from the destructor even when no exception is in flight.

While pathological, it would be nice if Catch defended against infinite loops. std::terminate() would be fine with me.

[kirkshoop]

FYI This hack works.

#include <exception>
namespace std {
inline bool uncaught_exception() noexcept(true) {return current_exception() != nullptr;}
}

#define CATCH_CONFIG_MAIN
#include "catch.hpp"

[philsquared]

Sorry for the delay - just catching up with this.
Firstly: thanks for reporting this - especially with all the background info - that makes things much easier to reason about (even if a bit frustrating in this case).
I tried your proposed workaround (more specifically I tried just checking for a current_exception() instead of uncaught_exception() ) and it doesn't work for me (clang/xcode 6.1.1).

Infinite loop detection is probably a good idea - although it doesn't really solve the problem. I'll see what I can do.

[ecorm]

I was testing code that makes use of std::exception_ptr and ran into a situation where the test case would be repeated infinitely for mysterious reasons. kirkshoop's hack fixed the problem (and restored my sanity). I'm using gcc 4.8.2 on Linux Mint.

[joto]

Is this the same as #271?

[philsquared]

For anyone still watching this issue - I've committed some changes (on Develop) that may address it. Please let me know either way if you try it.