Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch 2.9.2 enforces requirement libandroid #1743

Closed
fredcadete opened this issue Sep 5, 2019 · 2 comments
Closed

Catch 2.9.2 enforces requirement libandroid #1743

fredcadete opened this issue Sep 5, 2019 · 2 comments

Comments

@fredcadete
Copy link

Describe the bug
Due to #1710, catch2 now requires linking to libandroid.

Expected behavior
Expected to have the same linkage requirements as before (STL only).
Or, expected a compile-time option to not have this requirement.

Reproduction steps

  • Build 2.9.1 for Android, without linking to libandroid - OK
  • Build 2.9.2 for Android, without linking to libandroid - linkage fails. Cannot find __android_log_print , from writeToDebugConsole

Platform information:

  • OS: Ubuntu 18.04
  • Compiler+version: Clang 8.0.0
  • Catch version: 2.9.2

Additional context
In some cases it is desirable build for an Android target without expecting a requirement on the Android FW - libandroid included.

It's a nice feature btw, just would be good to opt out in some cases.
If this level of granularity in the compile-time options is not desirable by the project, I could live with patching my checkout of catch or undef'ing ANDROID at the inclusion point.

@horenmar
Copy link
Member

horenmar commented Sep 6, 2019

This should be doable in master now, can you test it out?

@fredcadete
Copy link
Author

👌

With master, defining "CATCH_CONFIG_NO_ANDROID_LOGWRITE" avoids the link to libandroid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants