This repository has been archived by the owner on Dec 3, 2019. It is now read-only.
mirrored from https://chromium.googlesource.com/catapult
-
Notifications
You must be signed in to change notification settings - Fork 563
Approve ES2017 Array.includes() #3424
Labels
Comments
Also relevant: the feature is widely implemented (Chrome 47, Firefox 43, Edge 14, Opera 34, Safari 9). |
sgtm, thanks! (Looks like the link is for indexOf, not includes) |
LGTM. |
@lpy This is definitely the policy. I'm going to start a conversation about this in an internal email thread to figure out how we should handle this wrt. code search, code review, etc. |
chromium-infra-bot
pushed a commit
that referenced
this issue
Mar 21, 2017
This is a follow-up CL to use the new best practices documented in http://crrev.com/2764813005. [email protected] BUG=catapult:#3424 Review-Url: https://codereview.chromium.org/2768513002
chromium-infra-bot
pushed a commit
that referenced
this issue
Mar 22, 2017
A follow-up CL to use this across the codebase is in progress here: http://crrev.com/2768513002. BUG=catapult:#3424 Review-Url: https://codereview.chromium.org/2764813005
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
ES 2017 introduces an
Array
/String.includes()
method that allows you to write:instead of
This new syntax has already slipped into the codebase without causing any problems. Are there any objections to marking it as approved?
@eakuefner @benshayden
The text was updated successfully, but these errors were encountered: