Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peel appart make_or_load_nwbfile context manager. #1143

Closed
h-mayorquin opened this issue Nov 14, 2024 · 1 comment
Closed

Peel appart make_or_load_nwbfile context manager. #1143

h-mayorquin opened this issue Nov 14, 2024 · 1 comment
Assignees

Comments

@h-mayorquin
Copy link
Collaborator

h-mayorquin commented Nov 14, 2024

The make_or_load_nwbfile has led to many errors and difficulties #1138 #1114 #911 #910 #912
Plus, even experienced programmers agree that this pattern is difficult to undersand a view which I strongly agree with.

After providing interfaces and converters with create_nwbfile we don't need this complication for anything other than append mode (opening a file from disk and adding data to it). We should use a normal write without context manager for the other cases.

@h-mayorquin
Copy link
Collaborator Author

Closed by #1180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant