-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build NuGet and Zip packages from TeamCity #57
Comments
@kkozmic, @jonorossi I may be overlooking something obvious, but I'm not sure how to make the remoting package. I see it, and I see the project in the source code, but I'm not seeing a build of the Remoting DLL either in my sandbox or in the artifacts on TeamCity. Ideas? |
@blairconrad Not a bother at all, you are getting things done. I recall @kkozmic removing the old remoting facility, and here is the commit dffc726. According to the diff stat @kkozmic got rid of the unit tests but accidentally left the actual code. Just ignore it for now. |
Perfect. Thanks. |
Everything needs a good checking-over, which I should get to on the weekend sometime, but I'm cautiously optimistic. |
In order to head off any surprises when the PR comes in, I mostly did the same thing here as for Castle.Core, but here are some deviations and notes:
|
@kkozmic, I noticed one difference in the nupkgs that I'm creating. A few of the text files, notably
all have LF line endings in the new nupkgs, but CRLFs in the old ones. I use a smart editor, so no skin off my nose, but the notepadders may be sad. I've tried and tried and tried to repair the files, but kept failing. I'm not a strong Gitter, but I think this is tied to ca095b9, specifically the new .gitattributes file. All the files that have LFs at the end of their lines have been modified since then. If this is intentional and expected, then I'll carry on. However, if we want CRLFs in the files, I'm at a bit of a loss. Could you tell me how you'd like me to proceed? Thanks/sorry. |
Of course, the bad line endings on the text files is something that can always be corrected after this issue is done, but before release. If I do my job right, we'll still pick up the files, however they're line-ended. |
hmm, good find re: line endings. Don't worry about it, I'll have a look into that. Like you said, it doesn't directly affect this issue. |
essentially the same as castleproject/Core#49:
Update the source and create a TeamCity build configuration ("Pack") to automatically build NuGet packages and a comprehensive Zip file for the Windsor projects.
I can take this. (Also, I thought I created this issue about 9 hours ago, but can't find it.)
The text was updated successfully, but these errors were encountered: