Release 5.1.0

[jonorossi]

This is the thread to make sure everything gets sorted for 5.1.0 so no one is wondering where things are at.

Here is the GitHub milestone with a bunch of Extensions.DependencyInjection facility issues, I've assigned a bunch of stuff but I need you guys to decide what you want in the next release:
https://github.com/castleproject/Windsor/milestone/7

Jump in if you want to help out, it doesn't have to be issues assigned to the milestone either.

/cc @generik0

[robertcoltheart]

What's the timeline for this please? We'd really like to use a stable version with ASP.NET 3.1.

[generik0]

@jonorossi @robertcoltheart @AntonioDrusin
I feel we are good now. Many people have been testing and all we maybe want to do is a cleanup of some of the code. But this can wait. It works we think.

@robertcoltheart please tell us, have you been using the beta. Any worries or issues?

[jonorossi]

I'll quote myself from the issue description:

I need you guys to decide what you want in the next release

If we don't need the issues assigned to the GitHub milestone, then we need to move them out before release.

[generik0]

@AntonioDrusin what do you think.
I am happy with the existing changes. Maybe worried a little if we need more documentation.

About other milestones, I do not feel anything else is critical like this is.

[robertcoltheart]

have you been using the beta. Any worries or issues?

Yes, and it seems to work for us, although I haven't tested any complicated wirings.

[generik0]

@jonorossi @AntonioDrusin @ltines There are to items still open. I think the #530 can be closed. I think #531 should just be documented. @AntonioDrusin any thoughts?

[generik0]

have you been using the beta. Any worries or issues?

Yes, and it seems to work for us, although I haven't tested any complicated wirings.

I have tested with signalr, cookie implemeantions, compression, node services and many many other deep freatures. It seams to be working!

[robertcoltheart]

I have actually found one issue, which is that if you provide your own container with WindsorServiceProviderFactory, there doesn't seem to be a root scope created. It probably just needs this:

		public WindsorServiceProviderFactory()
		{
			CreateRootContainer();
			CreateRootScope();
		}

		public WindsorServiceProviderFactory(IWindsorContainer container)
		{
			SetRootContainer(container);
			CreateRootScope(); // <-- Add this
		}

[robertcoltheart]

Everything else seems to be working for me. The only other adaption I had to make was with the missing AsMiddlware extension method, but I've worked my way around that, so it isn't an issue.

I'm good for this to go out as stable whenever you can please! 👍

[generik0]

Hi @jonorossi i will deep dive into to this again within the next 5 days. I have a break between projects.
After this i hope we can 5.1 :-)

[ltines]

@generik0 sorry for being bit MIA

For #531 I've opened PR to add more extensions
For #530 is a bigger question but I can see docu has been updated

So good for me

[robertcoltheart]

Any update on this? Can we get a stable release out now?

[generik0]

I just tested with docker and aspnetcore. This works also..
Great stuff...

@jonorossi anything missing for the release?

[jonorossi]

@generik0 issues still assigned to the milestone: https://github.com/castleproject/Windsor/milestone/7

[robertcoltheart]

The only item left is relating to transient services, for which we have documentation now, no? Can this issue be closed?

[generik0]

The only item left is relating to transient services, for which we have documentation now, no? Can this issue be closed?

I think so, please comment and close :-)

[generik0]

Hi all.

Just tested with official net core 5.
Spun-up like a charm

Cc/ @jonorossi @ltines @robertcoltheart

[jonorossi]

Hi all, everything assigned to the 5.1.0 milestone is now closed. I assume everyone is ready to release since there are no open issues, I'll make the release later today.

[jonorossi]

• Tagged v5.1.0
• Confirmed successfully pushed to nuget.org
• Tweeted

Thanks to @generik0, @robertcoltheart, @ltines, @twenzel and everyone that contributed to discussions and testing.

Please log new issues for anything you run into, happy to push out patch releases for fixes.