Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore 13 failing tests on master and v4.1.0 #438

Closed
jnm2 opened this issue Oct 6, 2018 · 12 comments
Closed

Ignore 13 failing tests on master and v4.1.0 #438

jnm2 opened this issue Oct 6, 2018 · 12 comments

Comments

@jnm2
Copy link
Contributor

jnm2 commented Oct 6, 2018

Some of these look like they date back a while. Would you be able to use [Ignore("reason/issue link")] on each failing test to help contributors know whether these failures are relevant to what we are doing?

One bonus is that you'll be able to run tests in CI and get a nice report of ignored issues in the console output as a TODO.

@mario-d-s
Copy link

@jnm2 Are those the tests that fail in #421? You are aware those only fail under specific circumstances (which I haven't been able to determine yet)?

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 8, 2018

Oh, I missed that issue! I'm pretty sure those are the same tests. I misunderstood the test: off in the appveyor script, sorry!

I'm on latest VS and ReSharper, as of Friday at least. Happy to help if there's a way.

@jnm2 jnm2 closed this as completed Oct 8, 2018
@mario-d-s
Copy link

No worries 😄 you could help by investigating why the tests do run when run from the full build script. What is different when running with R#? Or maybe those failing tests are also simply disabled from the build script somehow?

Either way, perhaps you know how to make the test code a little better so they don't fail under mysterious circumstances...

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2018

Sure, I'll see what I find.

May I draw your attention to #439? Haven't heard a response from anyone on the issue or PR yet, which is unusual.

@mario-d-s
Copy link

@jnm2 the more unusual thing to me is that @Fir3pho3nixx (Gavin) removed his account and did a major rage quit (or so it seems) on #420... I hope that guy is OK. I mailed him privately a few days ago but he didn't respond...

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2018

Yes, that is actually the unusual thing. I have no idea what happened. I mailed him a few days ago and haven't heard back either. Do hope he's okay. :-(

@jonorossi
Copy link
Member

@mario-d-s @jnm2 he too hasn't responded to my email. I've delayed posting anything publicly because I don't actually know the current situation. However, you guys are welcome to get more involved.

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2018

I'm not sure I can do anything else if he wants to be left alone for a while.

@jonorossi
Copy link
Member

I'm not sure I can do anything else if he wants to be left alone for a while.

Sorry, I meant more involved with Windsor.

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 9, 2018

Oh sorry, good thing to know. Thanks!

@mario-d-s
Copy link

@jonorossi I would like that, but I currently can't spend much time on open source unfortunately... I would definitely not be able to attain the energy levels of Gavin as he was powering through the work.

That said, it's high time I personally got up to speed with everything that is (ASP).NET Core. As this seems to be the next priority, perhaps I could help move it forward, but please do not interpret this as a commitment.

@jnm2
Copy link
Contributor Author

jnm2 commented Oct 11, 2018

Being able to get more involved would be fun and I might be able to do that in the future, but I also can't promise.

Back on topic:

Either way, perhaps you know how to make the test code a little better so they don't fail under mysterious circumstances...

#440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants