-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore 13 failing tests on master and v4.1.0 #438
Comments
Oh, I missed that issue! I'm pretty sure those are the same tests. I misunderstood the I'm on latest VS and ReSharper, as of Friday at least. Happy to help if there's a way. |
No worries 😄 you could help by investigating why the tests do run when run from the full build script. What is different when running with R#? Or maybe those failing tests are also simply disabled from the build script somehow? Either way, perhaps you know how to make the test code a little better so they don't fail under mysterious circumstances... |
Sure, I'll see what I find. May I draw your attention to #439? Haven't heard a response from anyone on the issue or PR yet, which is unusual. |
@jnm2 the more unusual thing to me is that @Fir3pho3nixx (Gavin) removed his account and did a major rage quit (or so it seems) on #420... I hope that guy is OK. I mailed him privately a few days ago but he didn't respond... |
Yes, that is actually the unusual thing. I have no idea what happened. I mailed him a few days ago and haven't heard back either. Do hope he's okay. :-( |
@mario-d-s @jnm2 he too hasn't responded to my email. I've delayed posting anything publicly because I don't actually know the current situation. However, you guys are welcome to get more involved. |
I'm not sure I can do anything else if he wants to be left alone for a while. |
Sorry, I meant more involved with Windsor. |
Oh sorry, good thing to know. Thanks! |
@jonorossi I would like that, but I currently can't spend much time on open source unfortunately... I would definitely not be able to attain the energy levels of Gavin as he was powering through the work. That said, it's high time I personally got up to speed with everything that is (ASP).NET Core. As this seems to be the next priority, perhaps I could help move it forward, but please do not interpret this as a commitment. |
Being able to get more involved would be fun and I might be able to do that in the future, but I also can't promise. Back on topic:
|
Some of these look like they date back a while. Would you be able to use
[Ignore("reason/issue link")]
on each failing test to help contributors know whether these failures are relevant to what we are doing?One bonus is that you'll be able to run tests in CI and get a nice report of ignored issues in the console output as a TODO.
The text was updated successfully, but these errors were encountered: