Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 5.0.0-beta001 #418

Closed
ghost opened this issue Jul 4, 2018 · 27 comments
Closed

Release 5.0.0-beta001 #418

ghost opened this issue Jul 4, 2018 · 27 comments
Milestone

Comments

@ghost
Copy link

ghost commented Jul 4, 2018

Can we release v5?

Any outstanding issues we need to look at?

/cc @stakx, @jonorossi

@ghost
Copy link
Author

ghost commented Jul 4, 2018

Sorry @stak accidentally tagged the wrong guy! Commuting and doing github on a mobile is apparently challenging - LOL

@ghost
Copy link
Author

ghost commented Jul 5, 2018

I think the MVC facility is not publishing it's symbols. :/

Scratch that. https://ci.appveyor.com/project/castleproject/windsor/build/0.0.471/artifacts

@jonorossi
Copy link
Member

@Fir3pho3nixx #346 is still assigned to the milestone in GitHub, happy for the milestone to be unassigned.

Did you want to release an official "5.0.0-beta1" to nuget.org to make sure everything with packaging works well giving you an easy chance to fix before final?

I don't think there is anything else I was expecting to be in 5.0, there is always more that can be done but there is no need to hold the ASP.NET Core facility up on that.

@ghost
Copy link
Author

ghost commented Jul 12, 2018

Forgot about that one! Do you mind if I have a quick refactor just to see how big this one is, if it is tiny we should definitely try and see if we can squeeze it in. Let me check and get back to you.

@ghost
Copy link
Author

ghost commented Jul 12, 2018

After re-reading the issue I remember now.

We were going to solve #346 at the surface level API's using a "Cheshire the cat" pattern. Let me put a PR together with dotMemory profiler results because we agreed to using a "copy on write" strategy here. That will hopefully inform us as to whether we can include it in this release or whether we need to do more work achieve this.

V5 on hold for PR.

@ghost
Copy link
Author

ghost commented Jul 12, 2018

Did you want to release an official "5.0.0-beta1" to nuget.org to make sure everything with packaging works well giving you an easy chance to fix before final?

Yes, please.

It also gives me a chance to start drafting the solution for danielpalme/IocPerformance#81.

I would also like to delete the copy of this facility in our code base at work. Hoping our New Relic monitoring will give us some last chance saloon for clearing things up.

@ghost
Copy link
Author

ghost commented Jul 12, 2018

@generik0, @xhafan If you can also help me validate the beta I would appreciate it heaps.

Thanks for all your help so far.

@generik0
Copy link
Contributor

@Fir3pho3nixx i Can. I will intergrate tomorrow and let it burn :-)

@xhafan
Copy link

xhafan commented Jul 13, 2018

@Fir3pho3nixx, I'm on it ;)

@xhafan
Copy link

xhafan commented Jul 13, 2018

Works like a charm. I tested it with the latest code from https://github.com/castleproject/Windsor, master branch (commit 81fbdf084d3b6e235ff54c4f29bbc8d93fd408ec).

In my app, the middleware is registered like this:

_windsorContainer.Register(
                Component.For<IUnitOfWorkFactory>().AsFactory(),
                Component.For<TransactionScopeUnitOfWorkMiddleware>()
                        .DependsOn(Dependency.OnValue<System.Transactions.IsolationLevel>(System.Transactions.IsolationLevel.Serializable))
                        .LifestyleSingleton().AsMiddleware()
);

Windsor then creates an instance of TransactionScopeUnitOfWorkMiddleware with IUnitOfWorkFactory injected into it.

@MAliM1988
Copy link

MAliM1988 commented Jul 21, 2018

Hi

What time is the release date of the new version of Windsor?

@ghost
Copy link
Author

ghost commented Jul 23, 2018

@MAliM1988

We are investigating #420. Once that is done, I don't see anything holding us back.

Thanks for the interest :)

@ghost
Copy link
Author

ghost commented Jul 31, 2018

State of play:

  1. API UX fail for WindsorRegistrationOptions in WindsorRegistrationExtensions.AddApplicationComponentsToWindsor #423. Should be fixed before beta.
  2. SomeFuckedUpShitInWindsorIWantToFix in Deprecating Resolve(Type, IDictionary) in favour of Resolve(Type, IReadOnlyDictionary<string, object>) #420. Not sure what we do with this, let's see what happens with typed factories first. Will update the docs for Deprecating Resolve(Type, IDictionary) in favour of Resolve(Type, IReadOnlyDictionary<string, object>) #420.

@ghost ghost self-assigned this Jul 31, 2018
@ghost
Copy link
Author

ghost commented Aug 3, 2018

State of play:

  1. API UX fail for WindsorRegistrationOptions in WindsorRegistrationExtensions.AddApplicationComponentsToWindsor #423. @MAliM1988 closed the issue so I am adding this to aspnet vNext here(https://github.com/fir3pho3nixx/Windsor/commit/14ad698c7df4eec8fa7c231807a622467e2bec11).
  2. After this, we are mulling over deprecating Resolve(object) because it is too general and causing problems with immutability.

@ghost
Copy link
Author

ghost commented Aug 23, 2018

State of play:

  1. API UX fail for WindsorRegistrationOptions in WindsorRegistrationExtensions.AddApplicationComponentsToWindsor #423. @MAliM1988 re-opened! Awaiting PR as per comment here.

  2. Final commits are in for Deprecating Resolve(Type, IDictionary) in favour of Resolve(Type, IReadOnlyDictionary<string, object>) #420 and awaiting review, we have deprecated object/IDictionary as parameters for IWindsorContainer.Resolve in favour of using Arguments with static factory methods instead.

@ghost
Copy link
Author

ghost commented Aug 29, 2018

@ghost
Copy link
Author

ghost commented Sep 16, 2018

Final commits are in for #420. Just needs squishing.

Also done some more testing with disposables. All good.

I think we are good to release now.

@ghost
Copy link
Author

ghost commented Oct 1, 2018

@jonorossi raised some issues that need addressing on #420. I also do not think the documentation is up to scratch either. I think we should release ASP.NET Core facility in the meantime. This simply needs more time.

@jonorossi do think we can do a pre-release?

@beginor
Copy link

beginor commented Oct 4, 2018

waiting for windsor 5.0.0 release!

@tapmantwo
Copy link

Hi, any news on a release? I'm keen to try the new aspnet core facility.

@stakx
Copy link
Member

stakx commented Oct 15, 2018

@tapmantwo, there's still one pending PR (#444) which needs to be merged first; quoting from #444 (comment):

[...] I'll get this merged and we can push out a beta for 5.0 with the ASP.NET Core changes.

@jonorossi jonorossi added this to the v5.0 milestone Oct 25, 2018
@jonorossi
Copy link
Member

#444 is now merged.

@castleproject/committers (just you @stakx now) is everyone happy with a 5.0.0-beta001 release?

@stakx
Copy link
Member

stakx commented Oct 25, 2018

@jonorossi - (with my best Super Mario Brothers Luigi voice:) let's-a-go!

@jonorossi
Copy link
Member

Ran into a problem with our build scripts, I guess we haven't released a beta in a while. Looking into it now.

obj\Release\netstandard1.6\Castle.Windsor.AssemblyInfo.cs(15,59): error CS7035: The specified version string does not conform to the recommended format - major.minor.build.revision [C:\projects\windsor\src\Castle.Windsor\Castle.Windsor.csproj]
obj\Release\net45\Castle.Windsor.AssemblyInfo.cs(15,59): error CS7035: The specified version string does not conform to the recommended format - major.minor.build.revision [C:\projects\windsor\src\Castle.Windsor\Castle.Windsor.csproj]

@jonorossi
Copy link
Member

  • Tagged v5.0.0-beta001
  • Confirmed successfully pushed to nuget.org, except Castle.Facilities.AspNetCore which unfortunately someone ("buddalasunil") has published a fork and unlisted it with the version "4.1.0". I've emailed them to get ownership transferred, will keep everyone informed on progress. (https://www.nuget.org/packages/Castle.Facilities.AspNetCore/4.1.0)
  • Tweeted (will do once the last package is up)

@jonorossi jonorossi changed the title Windsor v5.0.0 release Release 5.0.0-beta001 Oct 27, 2018
@jonorossi
Copy link
Member

Renamed this issue since it isn't the final 5.0.0 release. We'll create a new issue for that later once people have had a chance to play with the bits. Please get involved if you have problems or see areas for improvements.

Thanks again to everyone that contributed to this release.

@tapmantwo
Copy link

Fantastic, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants