-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 5.0.0-beta001 #418
Comments
Sorry @stak accidentally tagged the wrong guy! Commuting and doing github on a mobile is apparently challenging - LOL |
Scratch that. https://ci.appveyor.com/project/castleproject/windsor/build/0.0.471/artifacts |
@Fir3pho3nixx #346 is still assigned to the milestone in GitHub, happy for the milestone to be unassigned. Did you want to release an official "5.0.0-beta1" to nuget.org to make sure everything with packaging works well giving you an easy chance to fix before final? I don't think there is anything else I was expecting to be in 5.0, there is always more that can be done but there is no need to hold the ASP.NET Core facility up on that. |
Forgot about that one! Do you mind if I have a quick refactor just to see how big this one is, if it is tiny we should definitely try and see if we can squeeze it in. Let me check and get back to you. |
After re-reading the issue I remember now. We were going to solve #346 at the surface level API's using a "Cheshire the cat" pattern. Let me put a PR together with dotMemory profiler results because we agreed to using a "copy on write" strategy here. That will hopefully inform us as to whether we can include it in this release or whether we need to do more work achieve this. V5 on hold for PR. |
Yes, please. It also gives me a chance to start drafting the solution for danielpalme/IocPerformance#81. I would also like to delete the copy of this facility in our code base at work. Hoping our New Relic monitoring will give us some last chance saloon for clearing things up. |
@Fir3pho3nixx i Can. I will intergrate tomorrow and let it burn :-) |
@Fir3pho3nixx, I'm on it ;) |
Works like a charm. I tested it with the latest code from https://github.com/castleproject/Windsor, master branch (commit 81fbdf084d3b6e235ff54c4f29bbc8d93fd408ec). In my app, the middleware is registered like this: _windsorContainer.Register(
Component.For<IUnitOfWorkFactory>().AsFactory(),
Component.For<TransactionScopeUnitOfWorkMiddleware>()
.DependsOn(Dependency.OnValue<System.Transactions.IsolationLevel>(System.Transactions.IsolationLevel.Serializable))
.LifestyleSingleton().AsMiddleware()
); Windsor then creates an instance of TransactionScopeUnitOfWorkMiddleware with IUnitOfWorkFactory injected into it. |
Hi What time is the release date of the new version of Windsor? |
We are investigating #420. Thanks for the interest :) |
State of play:
|
State of play:
|
State of play:
|
State of play:
|
Final commits are in for #420. Just needs squishing. Also done some more testing with disposables. All good. I think we are good to release now. |
@jonorossi raised some issues that need addressing on #420. I also do not think the documentation is up to scratch either. I think we should release ASP.NET Core facility in the meantime. This simply needs more time. @jonorossi do think we can do a pre-release? |
waiting for windsor 5.0.0 release! |
Hi, any news on a release? I'm keen to try the new aspnet core facility. |
@tapmantwo, there's still one pending PR (#444) which needs to be merged first; quoting from #444 (comment):
|
@jonorossi - (with my best Super Mario Brothers Luigi voice:) let's-a-go! |
Ran into a problem with our build scripts, I guess we haven't released a beta in a while. Looking into it now.
|
|
Renamed this issue since it isn't the final 5.0.0 release. We'll create a new issue for that later once people have had a chance to play with the bits. Please get involved if you have problems or see areas for improvements. Thanks again to everyone that contributed to this release. |
Fantastic, thank you. |
Can we release v5?
Any outstanding issues we need to look at?
/cc @stakx, @jonorossi
The text was updated successfully, but these errors were encountered: