Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some source code string literals are not utf-8 #405

Closed
davidshen84 opened this issue Jun 2, 2018 · 2 comments
Closed

Some source code string literals are not utf-8 #405

davidshen84 opened this issue Jun 2, 2018 · 2 comments
Milestone

Comments

@davidshen84
Copy link

When trying to compile Windor on non-English platform, say Chinese, I got compilation errors that are caused by unrecognizable characters.

-			Assert.AreEqual("GenericHasNested< TOuter >.NestedGeneric<A2, AProp>[,,]", name);
+			Assert.AreEqual("GenericHasNested<·TOuter·>.NestedGeneric<A2, AProp>[,,]", name);

It turns out the file is not in utf-8 encoding. It would be nice if we save all source files in utf-8 encoding.

BTW, what is that · for?

@ghost
Copy link

ghost commented Jun 2, 2018

Hi @davidshen84

BTW, what is that · for?

Not entirely sure. Is it causing other problems apart for being incorrectly encoded?

@jonorossi
Copy link
Member

Fixed in #407.

@jonorossi jonorossi added this to the v5.0 milestone Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants