-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can we please rename this repository to Windsor.Quartz? #30
Comments
I don't really have an objection other than the .NET ecosystem has slowly moved to using package names to describe projects, it is a little annoying that people use "Castle.Core" (with the dot) to describe something in DynamicProxy but that is the way it is as that is how we ship it. This rename might confuse people to think "Windsor.Quartz" is the package name, what about "Windsor-Quartz"? With that said I've noticed when people fork the "Core" repo they then by default get a repo named "Core" in their user, doesn't quite make a lot of sense, but I didn't really want longer URLs and repos have more than one package anyway. @kristofdc @stakx did you have any preference? P.S. I've renamed |
@jonorossi - I might be missing some background information here, but why does Castle.Facilities.Quartz even get its own repository when all the other Windsor facilities are directly contained in the Windsor repository? If we merged Castle.Facilities.Quartz into Windsor, the naming issue raised here would simply evaporate, as this repo already follows the naming pattern used over at Windsor ("Castle.Facilities.*"). Other than that, I have no clear preference. A few stray thoughts for consideration:
|
P.S.: If you do decide to prefix every repo name with a "Castle." to match the NuGet package names, I have no objections. IMO, consistent names are more important than any one particular repo name, so in that regard I welcome @Fir3pho3nixx raising the naming topic. |
The Quartz facility was never part of any Windsor distribution, it was a contrib project that was always outside of Windsor just as there were heaps of other facilities for integration with Windows Fax Services, message queues and all sorts of things. It just happens that this one made its way from an old subversion repo into git and on our GitHub.
In a Windsor issue (castleproject/Windsor#339) we've actually been talking about the future of those facilities over the last 12 months, some have been deprecated and got moved to the deprecated org so that people can get at the source code easily but aren't shipped with Windsor anymore. We now only have 2 facilities left with the main Windsor distribution outside of
Agreed. Thanks for your comments, they align with where I was coming from when I renamed this repo a few months ago, we already had Castle.Transactions from many years ago but I didn't really like the name. So I guess that brings us to:
And we rename "Castle.Transactions" to just "Transactions". |
I am a fan of the |
Thanks for weighing in, I wasn't really strong either way so let's go with the dot and be done with it. No one else expressed any concerns. I've renamed both this and Castle.Transactions. |
Looks great :) |
I am just having trouble with the aesthetic naming of this project when viewed in github.
The good bit.
The ugly bit.
Can we please conventionalise our repository naming standards? Let's make it pretty again 🦄
The text was updated successfully, but these errors were encountered: