Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never use cached download when cask uses :latest #13206

Closed
vitorgalvao opened this issue Aug 12, 2015 · 4 comments
Closed

Never use cached download when cask uses :latest #13206

vitorgalvao opened this issue Aug 12, 2015 · 4 comments

Comments

@vitorgalvao
Copy link
Member

Refs #6087.

@vitorgalvao vitorgalvao added bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. labels Aug 12, 2015
@adidalal
Copy link
Contributor

Started taking a look at implementing this, even though my Ruby knowledge is pretty minimal. I haven't tested this, but:

The file to change is lib/hbc/download.rb

Under the perform def, add in a simple conditional check above the existing code.

  def perform(force=false)
    downloader.clear_cache if cask.version == :latest
    {snip... rest of code as already exists)
  end

@vitorgalvao
Copy link
Member Author

Sounds about right. Actually, we could make the change further down to downloader.clear_cache if force || cask.version == :latest.

@adidalal
Copy link
Contributor

Opened up a PR, do any tests need to be written?

@vitorgalvao
Copy link
Member Author

Shouldn’t be needed, but always a good idea to let @jawshooah have a look.

@miccal miccal removed bug Issue describing a reproducible bug. core Issue with Homebrew itself rather than with a specific cask. labels Dec 23, 2016
@Homebrew Homebrew locked and limited conversation to collaborators May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants