Change warning from red to yellow #12067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radeksimko
added
bug
Definitely debatable, since the intention with that might indeed be to reinstall the cask, and that has actually failed, so it is a valid warning. A blue Completely agree with this PR to change colour to yellow, though. |
radeksimko
added a commit
that referenced
this pull request
Jun 23, 2015
Change warning from red to yellow
miccal
removed
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings should not look the same as errors - i.e. should not be red IMO.
Example:
This PR changes it to:
In fact these "warnings" for "Cask is already installed" should even have a lower level than warning - maybe a Notice with blue colour or something like that, but this can be another PR.