From ea54924ae711bf8ad5160754c2cff3c8741d12bd Mon Sep 17 00:00:00 2001
From: Alexander Perfilyev <alexander.perfilyev@gmail.com>
Date: Tue, 18 Apr 2023 22:42:07 +0300
Subject: [PATCH 1/3] Create view intention and live template

---
 .../intentions/CreateViewIntention.kt         | 74 ++++++++++++++
 .../src/main/resources/META-INF/plugin.xml    |  4 +
 .../CreateViewIntention/description.html      |  5 +
 .../resources/liveTemplates/SqlDelight.xml    |  8 ++
 .../intentions/CreateViewIntentionTest.kt     | 98 +++++++++++++++++++
 5 files changed, 189 insertions(+)
 create mode 100644 sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
 create mode 100644 sqldelight-idea-plugin/src/main/resources/intentionDescriptions/CreateViewIntention/description.html
 create mode 100644 sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt

diff --git a/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
new file mode 100644
index 00000000000..e488caeefc8
--- /dev/null
+++ b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
@@ -0,0 +1,74 @@
+package app.cash.sqldelight.intellij.intentions
+
+import com.alecstrong.sql.psi.core.psi.SqlCompoundSelectStmt
+import com.alecstrong.sql.psi.core.psi.SqlCreateViewStmt
+import com.alecstrong.sql.psi.core.psi.SqlStmtList
+import com.alecstrong.sql.psi.core.psi.SqlTypes
+import com.intellij.codeInsight.intention.BaseElementAtCaretIntentionAction
+import com.intellij.codeInsight.template.TemplateManager
+import com.intellij.codeInsight.template.impl.TextExpression
+import com.intellij.openapi.command.WriteCommandAction
+import com.intellij.openapi.editor.Document
+import com.intellij.openapi.editor.Editor
+import com.intellij.openapi.project.Project
+import com.intellij.psi.PsiDocumentManager
+import com.intellij.psi.PsiElement
+import com.intellij.psi.util.PsiTreeUtil
+import com.intellij.psi.util.parentOfType
+import org.jetbrains.kotlin.psi.psiUtil.endOffset
+import org.jetbrains.kotlin.psi.psiUtil.startOffset
+
+internal class CreateViewIntention : BaseElementAtCaretIntentionAction() {
+
+  override fun getFamilyName(): String {
+    return INTENTIONS_FAMILY_NAME_REFACTORINGS
+  }
+
+  override fun getText(): String {
+    return "Create view"
+  }
+
+  override fun isAvailable(project: Project, editor: Editor?, element: PsiElement): Boolean {
+    val selectStmt = element.parentOfType<SqlCompoundSelectStmt>(true)
+    return selectStmt != null && selectStmt.parentOfType<SqlCreateViewStmt>() == null
+  }
+
+  override fun invoke(project: Project, editor: Editor, element: PsiElement) {
+    PsiDocumentManager.getInstance(project).commitAllDocuments()
+
+    val selectStmt = element.parentOfType<SqlCompoundSelectStmt>(true) ?: return
+    val stmtList = selectStmt.parentOfType<SqlStmtList>() ?: return
+    val container = stmtList.stmtList.firstOrNull { PsiTreeUtil.isAncestor(it, selectStmt, true) } ?: return
+
+    val semi = PsiTreeUtil.findSiblingForward(container, SqlTypes.SEMI, false, null) ?: return
+
+    val containerStart = container.startOffset
+    val containerEnd = semi.endOffset
+    val text = editor.document.getDocumentTextFragment(containerStart, containerEnd)
+    val offset = selectStmt.startOffset - containerStart
+
+    val templateManager = TemplateManager.getInstance(project)
+
+    WriteCommandAction.runWriteCommandAction(project) {
+      editor.document.deleteString(containerStart, containerEnd)
+
+      val template = templateManager.createTemplate("", "")
+      template.addTextSegment(text.substring(0, offset))
+      template.addTextSegment("SELECT * FROM ")
+      val expression = TextExpression("some_view")
+      template.addVariableSegment("NAME")
+      template.addSelectionStartVariable()
+      template.addTextSegment(text.substring(selectStmt.endOffset - containerStart))
+
+      template.addTextSegment("\n\nCREATE VIEW ")
+      template.addVariable("NAME", expression, true)
+      template.addTextSegment(" AS ${selectStmt.text};")
+
+      templateManager.startTemplate(editor, template)
+    }
+  }
+
+  private fun Document.getDocumentTextFragment(startOffset: Int, endOffset: Int): String {
+    return charsSequence.subSequence(startOffset, endOffset).toString()
+  }
+}
diff --git a/sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml b/sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml
index c372f045374..c7726d110e6 100644
--- a/sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml
+++ b/sqldelight-idea-plugin/src/main/resources/META-INF/plugin.xml
@@ -136,6 +136,10 @@
       <className>app.cash.sqldelight.intellij.intentions.QualifyColumnNameIntention</className>
       <category>SQLDelight</category>
     </intentionAction>
+    <intentionAction>
+      <className>app.cash.sqldelight.intellij.intentions.CreateViewIntention</className>
+      <category>SQLDelight</category>
+    </intentionAction>
 
     <copyPastePostProcessor
         implementation="app.cash.sqldelight.intellij.SqlDelightCopyPasteProcessor"/>
diff --git a/sqldelight-idea-plugin/src/main/resources/intentionDescriptions/CreateViewIntention/description.html b/sqldelight-idea-plugin/src/main/resources/intentionDescriptions/CreateViewIntention/description.html
new file mode 100644
index 00000000000..2409a734275
--- /dev/null
+++ b/sqldelight-idea-plugin/src/main/resources/intentionDescriptions/CreateViewIntention/description.html
@@ -0,0 +1,5 @@
+<html>
+<body>
+Creates a VIEW from SELECT statement
+</body>
+</html>
\ No newline at end of file
diff --git a/sqldelight-idea-plugin/src/main/resources/liveTemplates/SqlDelight.xml b/sqldelight-idea-plugin/src/main/resources/liveTemplates/SqlDelight.xml
index 066310c3965..6f257b122a1 100644
--- a/sqldelight-idea-plugin/src/main/resources/liveTemplates/SqlDelight.xml
+++ b/sqldelight-idea-plugin/src/main/resources/liveTemplates/SqlDelight.xml
@@ -68,4 +68,12 @@
       <option name="SQLDELIGHT" value="true" />
     </context>
   </template>
+  <template name="view" value="CREATE VIEW $view$ AS SELECT * FROM $table$$END$;"
+      description="new view definition" toReformat="false" toShortenFQNames="true">
+    <variable name="view" expression="" defaultValue="" alwaysStopAt="true"/>
+    <variable name="table" expression="complete()" defaultValue="" alwaysStopAt="true"/>
+    <context>
+      <option name="SQLDELIGHT" value="true"/>
+    </context>
+  </template>
 </templateSet>
diff --git a/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
new file mode 100644
index 00000000000..930bd8db12e
--- /dev/null
+++ b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
@@ -0,0 +1,98 @@
+package app.cash.sqldelight.intellij.intentions
+
+import app.cash.sqldelight.core.lang.SqlDelightFileType
+import app.cash.sqldelight.intellij.SqlDelightFixtureTestCase
+import com.google.common.truth.Truth.assertThat
+
+class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
+
+  fun testIntentionAvailableOnSelectStmt() {
+    myFixture.configureByText(
+      SqlDelightFileType,
+      CREATE_TABLE + """
+        |SELECT column_1
+        |FROM ta<caret>ble_1;
+      """.trimMargin(),
+    )
+
+    val intention = CreateViewIntention()
+
+    assertThat(
+      intention.isAvailable(
+        myFixture.project,
+        myFixture.editor,
+        myFixture.file.findElementAt(myFixture.editor.caretModel.offset)!!,
+      ),
+    )
+      .isTrue()
+  }
+
+  fun testIntentionNotAvailableInsideCreateView() {
+    myFixture.configureByText(
+      SqlDelightFileType,
+      CREATE_TABLE + """
+        |SELECT * FROM some_view;
+        |
+        |CREATE VIEW some_view AS SE<caret>LECT * FROM table_1;
+      """.trimMargin(),
+    )
+
+    val intention = CreateViewIntention()
+
+    assertThat(
+      intention.isAvailable(
+        myFixture.project,
+        myFixture.editor,
+        myFixture.file.findElementAt(myFixture.editor.caretModel.offset)!!,
+      ),
+    )
+      .isFalse()
+  }
+
+  fun testIntentionExecution() {
+    myFixture.configureByText(
+      SqlDelightFileType,
+      CREATE_TABLE + """
+        |SELECT column_1
+        |FROM table_1
+        |WHERE column_1 = (
+        |   SELECT co<caret>lumn_2
+        |   FROM table_2
+        |);
+      """.trimMargin(),
+    )
+
+    val intention = CreateViewIntention()
+    intention.invoke(
+      myFixture.project,
+      myFixture.editor,
+      myFixture.file.findElementAt(myFixture.editor.caretModel.offset)!!,
+    )
+
+    myFixture.checkResult(
+      CREATE_TABLE + """
+        |SELECT column_1
+        |FROM table_1
+        |WHERE column_1 = (
+        |   SELECT * FROM some_view
+        |);
+        |
+        |CREATE VIEW some_view AS SELECT column_2
+        |   FROM table_2;
+      """.trimMargin(),
+    )
+  }
+
+  companion object {
+    val CREATE_TABLE = """
+      |CREATE TABLE table_1 (
+      |  column_1 INTEGER NOT NULL
+      |);
+      |
+      |CREATE TABLE table_2 (
+      |  column_2 INTEGER NOT NULL
+      |);
+      |
+    """.trimMargin()
+  }
+}

From 2efc9d8305772ab72d0e1eef05a1c069d8932d86 Mon Sep 17 00:00:00 2001
From: Alexander Perfilyev <alexander.perfilyev@gmail.com>
Date: Tue, 18 Apr 2023 22:42:07 +0300
Subject: [PATCH 2/3] Create view intention and live template

---
 .../sqldelight/intellij/intentions/CreateViewIntention.kt     | 2 +-
 .../sqldelight/intellij/intentions/CreateViewIntentionTest.kt | 4 +++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
index e488caeefc8..5aa85d345c2 100644
--- a/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
+++ b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
@@ -69,6 +69,6 @@ internal class CreateViewIntention : BaseElementAtCaretIntentionAction() {
   }
 
   private fun Document.getDocumentTextFragment(startOffset: Int, endOffset: Int): String {
-    return charsSequence.subSequence(startOffset, endOffset).toString()
+    return charsSequence.subSequence(startOffset, endOffset).toString();
   }
 }
diff --git a/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
index 930bd8db12e..23a3b2c4e4a 100644
--- a/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
+++ b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
@@ -2,7 +2,9 @@ package app.cash.sqldelight.intellij.intentions
 
 import app.cash.sqldelight.core.lang.SqlDelightFileType
 import app.cash.sqldelight.intellij.SqlDelightFixtureTestCase
+import com.google.common.truth.Truth
 import com.google.common.truth.Truth.assertThat
+import junit.framework.TestCase
 
 class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
 
@@ -95,4 +97,4 @@ class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
       |
     """.trimMargin()
   }
-}
+}
\ No newline at end of file

From 66df8d2162d72939b1c558543c67e7a8f4d78ce2 Mon Sep 17 00:00:00 2001
From: Alexander Perfilyev <alexander.perfilyev@gmail.com>
Date: Wed, 19 Apr 2023 00:17:10 +0300
Subject: [PATCH 3/3] Change the order of the statements

---
 .../intentions/CreateViewIntention.kt         | 28 ++++++++++++-------
 .../intentions/CreateViewIntentionTest.kt     | 14 ++++------
 2 files changed, 24 insertions(+), 18 deletions(-)

diff --git a/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
index 5aa85d345c2..57e6d0dbad5 100644
--- a/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
+++ b/sqldelight-idea-plugin/src/main/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntention.kt
@@ -1,5 +1,6 @@
 package app.cash.sqldelight.intellij.intentions
 
+import app.cash.sqldelight.core.lang.psi.StmtIdentifier
 import com.alecstrong.sql.psi.core.psi.SqlCompoundSelectStmt
 import com.alecstrong.sql.psi.core.psi.SqlCreateViewStmt
 import com.alecstrong.sql.psi.core.psi.SqlStmtList
@@ -16,6 +17,7 @@ import com.intellij.psi.PsiElement
 import com.intellij.psi.util.PsiTreeUtil
 import com.intellij.psi.util.parentOfType
 import org.jetbrains.kotlin.psi.psiUtil.endOffset
+import org.jetbrains.kotlin.psi.psiUtil.getPrevSiblingIgnoringWhitespaceAndComments
 import org.jetbrains.kotlin.psi.psiUtil.startOffset
 
 internal class CreateViewIntention : BaseElementAtCaretIntentionAction() {
@@ -38,11 +40,18 @@ internal class CreateViewIntention : BaseElementAtCaretIntentionAction() {
 
     val selectStmt = element.parentOfType<SqlCompoundSelectStmt>(true) ?: return
     val stmtList = selectStmt.parentOfType<SqlStmtList>() ?: return
-    val container = stmtList.stmtList.firstOrNull { PsiTreeUtil.isAncestor(it, selectStmt, true) } ?: return
+    val container = stmtList.stmtList.firstOrNull {
+      PsiTreeUtil.isAncestor(it, selectStmt, true)
+    } ?: return
 
     val semi = PsiTreeUtil.findSiblingForward(container, SqlTypes.SEMI, false, null) ?: return
+    val psiElement = container.getPrevSiblingIgnoringWhitespaceAndComments()
 
-    val containerStart = container.startOffset
+    val containerStart = if (psiElement is StmtIdentifier) {
+      psiElement.startOffset
+    } else {
+      container.startOffset
+    }
     val containerEnd = semi.endOffset
     val text = editor.document.getDocumentTextFragment(containerStart, containerEnd)
     val offset = selectStmt.startOffset - containerStart
@@ -53,22 +62,21 @@ internal class CreateViewIntention : BaseElementAtCaretIntentionAction() {
       editor.document.deleteString(containerStart, containerEnd)
 
       val template = templateManager.createTemplate("", "")
-      template.addTextSegment(text.substring(0, offset))
-      template.addTextSegment("SELECT * FROM ")
       val expression = TextExpression("some_view")
-      template.addVariableSegment("NAME")
-      template.addSelectionStartVariable()
-      template.addTextSegment(text.substring(selectStmt.endOffset - containerStart))
 
-      template.addTextSegment("\n\nCREATE VIEW ")
+      template.addTextSegment("CREATE VIEW ")
       template.addVariable("NAME", expression, true)
-      template.addTextSegment(" AS ${selectStmt.text};")
+      template.addTextSegment(" AS ${selectStmt.text};\n\n")
 
+      template.addTextSegment(text.substring(0, offset))
+      template.addTextSegment("SELECT * FROM ")
+      template.addVariableSegment("NAME")
+      template.addTextSegment(text.substring(selectStmt.endOffset - containerStart))
       templateManager.startTemplate(editor, template)
     }
   }
 
   private fun Document.getDocumentTextFragment(startOffset: Int, endOffset: Int): String {
-    return charsSequence.subSequence(startOffset, endOffset).toString();
+    return charsSequence.subSequence(startOffset, endOffset).toString()
   }
 }
diff --git a/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
index 23a3b2c4e4a..c9b6c87edda 100644
--- a/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
+++ b/sqldelight-idea-plugin/src/test/kotlin/app/cash/sqldelight/intellij/intentions/CreateViewIntentionTest.kt
@@ -2,9 +2,7 @@ package app.cash.sqldelight.intellij.intentions
 
 import app.cash.sqldelight.core.lang.SqlDelightFileType
 import app.cash.sqldelight.intellij.SqlDelightFixtureTestCase
-import com.google.common.truth.Truth
 import com.google.common.truth.Truth.assertThat
-import junit.framework.TestCase
 
 class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
 
@@ -55,11 +53,11 @@ class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
     myFixture.configureByText(
       SqlDelightFileType,
       CREATE_TABLE + """
+        |select:
         |SELECT column_1
         |FROM table_1
         |WHERE column_1 = (
-        |   SELECT co<caret>lumn_2
-        |   FROM table_2
+        |   SELECT co<caret>lumn_2 FROM table_2
         |);
       """.trimMargin(),
     )
@@ -73,14 +71,14 @@ class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
 
     myFixture.checkResult(
       CREATE_TABLE + """
+        |CREATE VIEW some_view AS SELECT column_2 FROM table_2;
+        |
+        |select:
         |SELECT column_1
         |FROM table_1
         |WHERE column_1 = (
         |   SELECT * FROM some_view
         |);
-        |
-        |CREATE VIEW some_view AS SELECT column_2
-        |   FROM table_2;
       """.trimMargin(),
     )
   }
@@ -97,4 +95,4 @@ class CreateViewIntentionTest : SqlDelightFixtureTestCase() {
       |
     """.trimMargin()
   }
-}
\ No newline at end of file
+}