Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues under Edge #207

Open
tzvetelin-vassilev opened this issue Mar 6, 2018 · 2 comments
Open

Issues under Edge #207

tzvetelin-vassilev opened this issue Mar 6, 2018 · 2 comments

Comments

@tzvetelin-vassilev
Copy link

Hi there,

I have some issues under Edge. I found that under
updateScrollParent, where mousewheel event is added updateFrame not happens.

getScrollParent under Edge also have problems. All browsers instead Edge when set overflow-x: hidden, makes overflow-y: auto, so with axis y this would be scrollParent. But Edge do not change its default value and overflow-y is visible. It would be great to handle Edge and to check also and other axis.

@tzvetelin-vassilev
Copy link
Author

Is anybody there? I already have fixed the issue. What is proper way to contribute with the fix?

@tzvetelin-vassilev
Copy link
Author

Well, scrollParentGetter property resolves this issue. Anyhow it would be more convenient to fix defaultScrollParentGetter. Instead

while (el = el.parentElement) {
	switch (window.getComputedStyle(el)[overflowKey]) {
		case 'auto': case 'scroll': case 'overlay': return el;
	}
}

you can update to:

let otherAxisOverflowKey = OVERFLOW_KEYS[axis == 'x' ? 'y' : 'x' ];

while (el = el.parentElement) {
	if (['auto', 'scroll', 'overlay'].includes(window.getComputedStyle(el)[overflowKey]) || window.getComputedStyle(el)[otherAxisOverflowKey] == 'hidden')
		return el;
}

which handles Edge bug and not requires using of scrollParentGetter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant