Skip to content

Commit f8a7e2f

Browse files
committed
fix: Incorporate Exclude in splitBy signature.
As Moshe used it in ReactiveX/rxjs#5441
1 parent 2359d1f commit f8a7e2f

File tree

1 file changed

+6
-8
lines changed

1 file changed

+6
-8
lines changed

source/operators/splitBy.ts

+6-8
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import { bucketBy } from "./bucketBy";
99
export function splitBy<T, S extends T>(
1010
predicate: (value: T, index: number) => value is S,
1111
subjectSelector?: () => Subject<T>
12-
): OperatorFunction<T, [Observable<S>, Observable<T>]>;
12+
): OperatorFunction<T, [Observable<S>, Observable<Exclude<T, S>>]>;
1313

1414
export function splitBy<T>(
1515
predicate: (value: T, index: number) => boolean,
@@ -20,11 +20,9 @@ export function splitBy<T>(
2020
predicate: (value: T, index: number) => boolean,
2121
subjectSelector: () => Subject<T> = () => new Subject<T>()
2222
): OperatorFunction<T, [Observable<T>, Observable<T>]> {
23-
return (
24-
bucketBy(
25-
2,
26-
(value, index) => (predicate(value, index) ? 0 : 1),
27-
subjectSelector
28-
) as OperatorFunction<T, [Observable<T>, Observable<T>]>
29-
);
23+
return bucketBy(
24+
2,
25+
(value, index) => (predicate(value, index) ? 0 : 1),
26+
subjectSelector
27+
) as OperatorFunction<T, [Observable<T>, Observable<T>]>;
3028
}

0 commit comments

Comments
 (0)