Skip to content

Commit 2e1366e

Browse files
authored
Bugfix semver parse (#229)
* fix bug in S3 Repo parsing version number from artifact * changelog
1 parent 13ffaf4 commit 2e1366e

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

CHANGELOG.md

+7
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,14 @@ Documenting All Changes to the Skelebot Project
33

44
---
55

6+
## v1.33.1
7+
#### Changed
8+
- **S3Repo** | Fixed a bug in S3Repo where the artifact version was not being parsed properly in some cases
9+
10+
---
11+
612
## v1.33.0
13+
#### Merged: 2022-09-09
714
#### Added
815
- **Git Templates** | Added the ability to load templates from Git repos in scaffolding
916

VERSION

+1-1
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
1.33.0
1+
1.33.1

skelebot/components/repository/s3Repo.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,8 @@ def pull(self, artifact, version, currentVersion=None, override=False, user=None
7070

7171
# Iterate through all the artifacts int he bucket
7272
for content in response["Contents"]:
73-
artifactSemver = Semver(str(content["Key"]).split("_v")[1].split(ext)[0])
73+
artifactName = str(content["Key"]).split("/")[-1]
74+
artifactSemver = Semver(artifactName.split("_v")[-1].split(ext)[0])
7475

7576
# Find the most recent backward compatible version AKA Latest Compatible Version (LCV)
7677
if (currentSemver.isBackwardCompatible(artifactSemver)) and ((version is None) or (version < artifactSemver)):

0 commit comments

Comments
 (0)