Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure versions of sandpaper and varnish can be pinned #66

Closed
zkamvar opened this issue Feb 1, 2021 · 2 comments
Closed

Ensure versions of sandpaper and varnish can be pinned #66

zkamvar opened this issue Feb 1, 2021 · 2 comments

Comments

@zkamvar
Copy link
Contributor

zkamvar commented Feb 1, 2021

One thing that was brought up by @tobyhodges is the concept that people like to be able to tweak the template. At the moment, this is not explicitly possible, but it is possible without too much effort by piggybacking on {pkgdown}'s approach to allowing custom templates a la tidytemplate: https://tidytemplate.tidyverse.org/ (which is exactly what we did with {varnish}).

Another aspect is the fact that some instructors like to tweak the lessons by forking the official lessons. We want to make sure that they don't have to go through any changes to the site if they don't want to.

Both of these aspects can be achieved by introducing a mechanism by which users can lock the versions of sandpaper and varnish needed to build the site.

@zkamvar zkamvar added this to the beta milestone Feb 1, 2021
@zkamvar
Copy link
Contributor Author

zkamvar commented Apr 7, 2022

Note: this has been partially acheived in https://github.com/carpentries/actions/releases/tag/v0.8

@zkamvar
Copy link
Contributor Author

zkamvar commented Jan 20, 2023

This was fixed in #270

@zkamvar zkamvar closed this as completed Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant