Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes in license in config.yaml does not show up on rendered page. #619

Closed
chrbknudsen opened this issue Nov 12, 2024 · 1 comment · Fixed by #620
Closed

Changes in license in config.yaml does not show up on rendered page. #619

chrbknudsen opened this issue Nov 12, 2024 · 1 comment · Fixed by #620
Assignees

Comments

@chrbknudsen
Copy link

Changing the standard license to something else does not change the license shown on the final lesson.
I have tried changing the license-value both manually, and using sandpaper::set_config(pairs = c(license = "CC0"), write = TRUE).

An example of a build site:
https://chrbknudsen.github.io/R-toolbox/

The corresponding config.yaml, containg license: 'CC0':
https://github.com/chrbknudsen/R-toolbox/blob/main/config.yaml

@froggleston
Copy link
Contributor

Hi @chrbknudsen - thanks for spotting this. I think it's an issue with fill_translation_vars where the incoming metadata doesn't seem to have the license so defaults back to CC-BY 4.0. I'll do more digging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants