Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-cliff failed because its tarball contains { bin }{ binary-ext }-{ version } #439

Closed
NobodyXu opened this issue Sep 28, 2022 · 4 comments · Fixed by #441
Closed

git-cliff failed because its tarball contains { bin }{ binary-ext }-{ version } #439

NobodyXu opened this issue Sep 28, 2022 · 4 comments · Fixed by #441

Comments

@NobodyXu
Copy link
Member

NobodyXu commented Sep 28, 2022

I have tested that this PR indeeds fixed #357 and now sccache can install without problem.
I've also added sccache to CI.

However git-cliff still fails because the tarball contains git-cliff-{ version }, that will require another PR.

Originally posted by @NobodyXu in #438 (comment)

@NobodyXu
Copy link
Member Author

There are two ways to fix this:

  • We could submit a PR to git-cliff
  • We can improve auto discovery for this use case.

@passcod What's your thought on this?

@passcod
Copy link
Member

passcod commented Sep 28, 2022

Oh it's in a folder named { name }-{ version }, not the binary is named { name }-{ version }. I think we should support that, yes

@NobodyXu
Copy link
Member Author

@azzamsa Note that #441 almost makes it possible to install git-cliff.

However, the official pre-built artifacts in the latest release on the github repo does not contain git-cliff-completions and git-cliff-mangen, which is not optional.

This is an upstream issue, not somethint cargo-binstall can fix.

@passcod
Copy link
Member

passcod commented Sep 28, 2022

Hmm, we could introduce an option like --ignore-missing-bins, to just attempt to install regardless of what's missing. But yeah agree in this case that git-cliff should just mark those optional if they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants