Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non archived binaries are not executable #406

Closed
fgardt opened this issue Sep 22, 2022 · 5 comments · Fixed by #433
Closed

non archived binaries are not executable #406

fgardt opened this issue Sep 22, 2022 · 5 comments · Fixed by #433
Assignees
Labels
Report: enhancement Request for improvements to existing features or code

Comments

@fgardt
Copy link

fgardt commented Sep 22, 2022

I wanted to get clippy-sarif with cargo-binstall and used the described way to get unsupported crates like so:

cargo binstall \ 
    --pkg-url="{ repo }/releases/download/{ name }-v{ version }/{ name }-{ target }" \
    --pkg-fmt="bin" clippy-sarif

note: for crates from sarif-rs it would've been nice to allow to get multiple crates since they all use the same overrides for --pkg-url and --pkg-fmt

The binary installs just fine at the right location etc but when trying to run it you can't because it is not marked executable.
It would be nice if cargo-binstall would mark binaries as executable so I don't need to run chmod +x -R ~/.cargo/bin

@NobodyXu
Copy link
Member

note: for crates from sarif-rs it would've been nice to allow to get multiple crates since they all use the same overrides for --pkg-url and --pkg-fmt

I think that is possible.
Just provides multiple crate name.

@NobodyXu
Copy link
Member

It would be nice if cargo-binstall would mark binaries as executable so I don't need to run chmod +x -R ~/.cargo/bin

Sure!

@NobodyXu NobodyXu added the Report: enhancement Request for improvements to existing features or code label Sep 22, 2022
@NobodyXu NobodyXu self-assigned this Sep 22, 2022
@fgardt
Copy link
Author

fgardt commented Sep 22, 2022

note: for crates from sarif-rs it would've been nice to allow to get multiple crates since they all use the same overrides for --pkg-url and --pkg-fmt

I think that is possible.
Just provides multiple crate name.

Are you saying that this is already possible or that it should be easy to add?
Because it is not currently possible as far as I can tell:
image

@NobodyXu
Copy link
Member

Are you saying that this is already possible or that it should be easy to add?

It's definitely possible.
The error were introduced when we added support for multiple binaries, we can adjust that for this use case.

@NobodyXu
Copy link
Member

NobodyXu commented Sep 28, 2022

@fgardt cargo-binstall v0.14.0 has released which fixed this issue.

note: for crates from sarif-rs it would've been nice to allow to get multiple crates since they all use the same overrides for --pkg-url and --pkg-fmt

I forgot to implement this in this release, would do that in next release.
Anyway, I would create a new issue for it in #444.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Report: enhancement Request for improvements to existing features or code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants