Enabling warnings as errors (#38)

careem · Jun 10, 2021 · 59d7269 · 59d7269
1 parent fb46402
commit 59d7269
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,6 +4,7 @@ All notable changes to this project will be documented in this file.
 ---
 
 ## master
+* Enabled warnings as errors
 * Enabled `explictApi()` mode
 
 ## 1.10.0

diff --git a/build.gradle b/build.gradle
@@ -39,6 +39,10 @@ allprojects {
         maven { url "https://kotlin.bintray.com/kotlinx" }
         maven { url "https://plugins.gradle.org/m2/" }
     }
+
+    tasks.withType(org.jetbrains.kotlin.gradle.tasks.KotlinCompile).all {
+        kotlinOptions.allWarningsAsErrors = true
+    }
 }
 
 void setupMultiplatformLibrary(Project project, Boolean shouldPublish = true) {

diff --git a/mockingbird/src/commonMain/kotlin/com/careem/mockingbird/test/Capture.kt b/mockingbird/src/commonMain/kotlin/com/careem/mockingbird/test/Capture.kt
@@ -45,6 +45,7 @@ public fun <T> capture(list: CapturedList<T>): CapturedMatcher<T> {
  * A slot using to fetch the method invocation and compare the property inside invocation arguments
  * Usage example @see [FunctionsTest]
  */
+
 public class Slot<T> : Captureable {
     private val _captured: AtomicRef<T?> = atomic(null)
     public var captured: T?
@@ -55,6 +56,7 @@ public class Slot<T> : Captureable {
             _captured.value = value
         }
 
+    @Suppress("UNCHECKED_CAST")
     override fun storeCapturedValue(value: Any?) {
         captured = value as T
     }
@@ -72,6 +74,7 @@ public class CapturedList<T> : Captureable {
             return _captured.access { it.toList() }
         }
 
+    @Suppress("UNCHECKED_CAST")
     override fun storeCapturedValue(value: Any?) {
         _captured.access { it.add(value as T) }
     }

diff --git a/mockingbird/src/commonMain/kotlin/com/careem/mockingbird/test/Functions.kt b/mockingbird/src/commonMain/kotlin/com/careem/mockingbird/test/Functions.kt
@@ -141,6 +141,7 @@ public fun <T : Mock, R> T.mock(methodName: String, arguments: Map<String, Any?>
     return invocationRecorder.access { recorder ->
         val invocation = Invocation(methodName = methodName, arguments = arguments)
         recordInvocation(hashCode, recorder, invocation)
+        @Suppress("UNCHECKED_CAST")
         return@access recorder.getResponse(hashCode, invocation) as R
     }
 }
@@ -185,6 +186,7 @@ public fun <T : Spy, R> T.spy(
     return invocationRecorder.access { recorder ->
         val invocation = Invocation(methodName = methodName, arguments = arguments)
         recordInvocation(hashCode, recorder, invocation)// TODO change name
+        @Suppress("UNCHECKED_CAST")
         val mockResponse = recorder.getResponse(
             instanceHash = hashCode,
             invocation = invocation,