Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some packages from cardano-wallet to CHaP #949

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

abailly
Copy link

@abailly abailly commented Dec 10, 2024

@sourabhxyz
Copy link

Hi @abailly, thank you for this PR! I am wondering about it's status, is there something pending or are we awaiting approval?

@abailly
Copy link
Author

abailly commented Dec 13, 2024

AFAIK we are waiting approval, but this is beyond my karma level :)

@sourabhxyz
Copy link

sourabhxyz commented Dec 14, 2024

Might be worth creating a CF team & giving update privileges to it for packages added by this PR.

@abailly
Copy link
Author

abailly commented Dec 16, 2024

Might be worth creating a CF team & giving update privileges to it for packages added by this PR.

Sure, that would be great :)

@disassembler
Copy link
Contributor

approved for CI run. WIll review after it finishes.

@disassembler
Copy link
Contributor

Looks like you need a rebase

@abailly abailly force-pushed the main branch 3 times, most recently from c4aae3d to b3ea52a Compare December 19, 2024 15:40
@abailly
Copy link
Author

abailly commented Dec 19, 2024

It seems there's something wrong with the build environment provided by nix but I have no idea why: https://github.com/IntersectMBO/cardano-haskell-packages/actions/runs/12416333194/job/34664923801#step:7:2649
Any nix expert around that could help @disassembler @angerman ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial CHaP release
3 participants