Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI unnecessarily asks for password when posting transaction from a non-existing wallet #398

Closed
piotr-iohk opened this issue Jun 11, 2019 · 1 comment
Assignees

Comments

@piotr-iohk
Copy link
Contributor

piotr-iohk commented Jun 11, 2019

Release Operating System Cause
next Linux Code v Configuration v Environment v Human v Unknown

Context

When trying to post tx and providing wallet id that is valid 40 char hex encoded string (yet not belonging to existing wallet), the CLI is asking for password, and only after providing the password it shows message that I couldn't find a wallet with the given id: <walletId>.
Instead, the CLI should not ask for password but return the message immediatelly.

Steps to Reproduce

  1. Run cardano-wallet transaction create --port=<port> 1111111111111111111111111111111111111111 --payment 22@2cWKMJemoBahmFD6eqM76PqSVxxbobW4QbnF2ApBbR1c7JcrEhyq8S8YSrweZJPGGBcoY

Expected behavior

Error message:
I couldn't find a wallet with the given id: <walletId>
Exit code = 1

Actual behavior

Password prompt appears:
Please enter a passphrase:
And error message just after providing a password:
I couldn't find a wallet with the given id: <walletId>


Resolution Plan

PR

Number Base
#399 develop

QA

On #399 I have also modified CLI integration tests (the ones tagged TRANS_CREATE_07) to make sure CLI does not ask for password in case non-existing wallet is provided.

@piotr-iohk piotr-iohk added the BUG label Jun 11, 2019
@piotr-iohk piotr-iohk self-assigned this Jun 12, 2019
@KtorZ KtorZ added this to the Bugs Sprint 23-24 milestone Jun 12, 2019
@KtorZ KtorZ added CONFIRMED and removed BUG labels Jun 14, 2019
@KtorZ
Copy link
Member

KtorZ commented Jun 14, 2019

👍

@KtorZ KtorZ closed this as completed Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants