Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GenesisParameters from wallet checkpoints #1872

Closed
1 task
Anviking opened this issue Jul 7, 2020 · 2 comments
Closed
1 task

Remove GenesisParameters from wallet checkpoints #1872

Anviking opened this issue Jul 7, 2020 · 2 comments
Assignees

Comments

@Anviking
Copy link
Member

Anviking commented Jul 7, 2020

Context

In ADP-356 we are integrating with Hard Fork Combinator.

In each wallet checkpoint we are currently storing:

checkpointGenesisHash       BlockId      sql=genesis_hash
checkpointGenesisStart      UTCTime      sql=genesis_start
checkpointFeePolicyUnused   Text         sql=fee_policy
checkpointSlotLength        Word64       sql=slot_length
checkpointEpochLength       Word32       sql=epoch_length
checkpointTxMaxSizeUnused   Word16       sql=tx_max_size
checkpointEpochStability    Word32       sql=epoch_stability
checkpointActiveSlotCoeff   Double       sql=active_slot_coeff

Note that

  • epochLength, slotLength may change in the byron-to-shelley transition, but I don't think wallet checkpoints are suitable for keeping track of this.
  • epochStability (i.e. k/ securityParam) is completely static
  • We store recent TxParameters in a separate table
  • We verify the genesisHash of the stored genesis checkpoint (seems useful)

Decision

I think we should remove everything but genesisHash.

Acceptance Criteria

  • Redundant and potentially confusing information should be removed from wallet checkpoints

Development

#1983

QA

@Anviking
Copy link
Member Author

@rvl
Copy link
Contributor

rvl commented Aug 4, 2020

Yes when we have a better db migration system we can revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants