Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery from chain-following exceptions may cause node to crash #1572

Closed
Anviking opened this issue Apr 15, 2020 · 1 comment
Closed

Recovery from chain-following exceptions may cause node to crash #1572

Anviking opened this issue Apr 15, 2020 · 1 comment

Comments

@Anviking
Copy link
Member

Context

Information -
Version
Platform
Installation

The chain following code will recover from errors and retry immediately.

It is not throttled, which might lead to a (fast) infinite loop.

Follow-up to #1505 where it seemed that the node was crashing because of this.

Steps to Reproduce

Imagined:

  • Throw exception in chain-follower

Expected behavior

  • Wallet either 1) crashes or 2) retries at a calm rate
  • Node should not crash in the second case

Actual behavior


Resolution


QA

@KtorZ
Copy link
Member

KtorZ commented Aug 3, 2020

That is no longer the case, the wallet now "sleeps" between each retry and only retry "retryable" exceptions. Other will simply lead to crash.

@KtorZ KtorZ closed this as completed Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants