-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Data additions for v1 #104
Comments
I started to initially prototype with the 3D
Something else to consider: are we intent on showing all possible years across all datasets? This would really simplify the UI for distinct time domains and, especially in the 4D approach, decrease the amount of data we need to load. Curious for your thoughts here in particular @tcchiao @orianac! The UI concerns can definitely be solved given a little thought. |
Sounds good @katamartin! re: the time extent question, it'd be nice to be able to show the 2001-2014 portion for v0. Though restricting the emissions to just the intersecting time period of 2015-2020 would be fine, and make v0 look more like a comparison dataset as opposed to a core product. It would introduce a tiny bit of backward compatibility in terms of the blog post (we said it was available 2001-2020) but that might be unimportant in the grand scheme of things. Out of curiosity, would it be possible to have the 2001-2014 portion as an a separate layer that you could optionally turn on? Would that help with anything? A less extreme example of the time extent inconsistency is that for the use case of comparing biomass and v1 emissions, people are likely going to be comparing emissions at time |
Great discussion! A couple thoughts to add:
|
I could totally see this as a separate toggle only enabled when looking at v0 data! I think this could help with making the data viewable in the tool but not drawing attention to it by default (which we definitely would by making the default, top-level time slider 2001-2020). Separately, started a very rough draft PR #106 for pulling in the v1 data, which is mostly working! One small issue we noticed was we're specifying variable with |
just to expand on the chunk point, in general we want just one chunk across the non-spatial dimensions, so the chunk size should always match the array size on those dimensions, i.e. if with more layers the shape is we will surely relax that when we figure out how to stream chunked data on demand along non-spatial dimensions, but we're not quite there yet :) |
and if we're going to keep 2001-2014 for v0, i do like the idea of having the time slider only show the longer range when v0 is selected (and if you have slided to an earlier year and then select a different layer, it'll jump to 2014) especially cause you'll only be able to select one at a time, that seems pretty clean to me! |
Documenting conversation from yesterday: the plan is to show data from 2014-2020. |
Closing this issue out for now while we continue to work with the v1 data. |
We had a very productive call today discussing the data configurations we want to test while adding the v1 data layers to this map tool. This issue documents the outputs of that call:
The text was updated successfully, but these errors were encountered: