Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Disable Modal for TagSet component #5726

Open
2 tasks done
jeesonjohnson opened this issue Jul 25, 2024 · 2 comments · May be fixed by #5753
Open
2 tasks done

[Feature Request]: Disable Modal for TagSet component #5726

jeesonjohnson opened this issue Jul 25, 2024 · 2 comments · May be fixed by #5753
Labels
component: TagSet role: dev type: community contribution 👐 Issues that may be completed by contributors from our community type: enhancement 💡 New feature or request
Milestone

Comments

@jeesonjohnson
Copy link

The problem

Currently, we do not have the option to disable the TagSet overflow modal. This is currently an issue for our product, since we chose to disable this component, in favour of our own custom component with custom functionality. However, with how the code is set up currently, the inbuilt TagSetModal cannot be disabled. See here. We have disabled it manually using CSS overrides. However, we would rather it be disabled by the use of a prop, so that the DOM does not become overly populated unnecessarily.

The solution

Pass down a prop called, showOverflowModal (defaulted to true) that will disable the rendering of the component within the TagSet component.

NOTE: I am happy to do this change, raise the appropriate PRs and do related testing. Just wanted to approval before attempting to make this change.

Design link

N/A

Links to other materials

Related code that needs to be changed: https://github.com/carbon-design-system/ibm-products/blob/main/packages/ibm-products/src/components/TagSet/TagSet.tsx#L402-L412

Owner/main maintainer(s)

IBM Products

Second/backup maintainer(s)

No response

Product/offering

IBM Cloud Pak For Integration

Business priority

Low Priority = release date is not dependent on fix or not upcoming

Code of Conduct

@oliviaflory
Copy link

@matthewgallo following up with Michael G

@jeesonjohnson
Copy link
Author

Hey @matthewgallo / @oliviaflory, has there been any update on this?

@oliviaflory oliviaflory added the type: community contribution 👐 Issues that may be completed by contributors from our community label Sep 19, 2024
@oliviaflory oliviaflory added this to the 2024 Q4 milestone Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: TagSet role: dev type: community contribution 👐 Issues that may be completed by contributors from our community type: enhancement 💡 New feature or request
Projects
Status: Community backlog 🚞
Development

Successfully merging a pull request may close this issue.

2 participants