Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement proposal: grouping for NotificationsPanel #4924

Closed
a-roberts opened this issue Apr 17, 2024 · 3 comments
Closed

Enhancement proposal: grouping for NotificationsPanel #4924

a-roberts opened this issue Apr 17, 2024 · 3 comments

Comments

@a-roberts
Copy link

a-roberts commented Apr 17, 2024

What will this achieve?

we'd love to be able to use the NotificationsPanel to group similar errors by, say, title or description.

This could be achieved on the UI through:

image

which would be provided for each Notification where there are similar problems (or anything else we would want to group).

There are several ways this could be implemented - a simple "doGrouping" type prop (that'd be a boolean) and would look for some known prop (say, the title), and if set, instead of producing new Notification items, we'd have them available via clicking to view more. They could be available via the hidden items now showing as they would without grouping.

Another way would be via a set of enums (e.g. groupOn={foo|bar|baz}) where items could be grouped based on specific props provided to the NotificationsPanel (e.g. title, description, anything else).

And another way would involve a custom grouping function that could be applied for each element found.

How will success be measured?

This question "how will success be measured" is confusing in this case given this is an enhancement request so that we needn't create our own NotificationsPanel-like component, or do grouping via another rudimentary way.

Additional information

  • Designs
  • Existing code
  • etc
@aubrey-oneal
Copy link
Member

aubrey-oneal commented Jun 10, 2024

Hey @a-roberts we are looking into working on this but could use a little more info. Is there a more fleshed out design we can follow? It would also be great if you could list 1 or more product teams that could use this.

Notes for Product team to chat about:

  • See this image of Notifications to see where this feature enhancement would be applied
  • Chat with Core. This issue may move over there (related to Ben's work)
  • Core also has the shell enhancement umbrella issue: UI Shell updates ☂️ carbon#16296
  • Check if any of this is coded in storybook
  • Needs additional design work. I.e. What does it look like when the user switches between grouping types

Copy link
Contributor

This issue is stale because it has been open for 30 days with no activity.
Remove the stale label or add a comment, otherwise this issue will be closed in 14 days.

Copy link
Contributor

This issue was closed because it has received no activity for 14 days.

@github-actions github-actions bot added the status: won’t fix 🔚 This will not be worked on label Aug 29, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 🚀
Development

No branches or pull requests

3 participants