Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery component enhancements #237

Closed
alisonjoseph opened this issue Jul 11, 2019 · 9 comments
Closed

Gallery component enhancements #237

alisonjoseph opened this issue Jul 11, 2019 · 9 comments
Labels
status: needs design spec Development can't progress without a design spec type: enhancement 💡

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Jul 11, 2019

Internal issue:https://github.ibm.com/brand/design-language/issues/40

Moved from https://github.ibm.com/duo/website/issues/1223 & https://github.ibm.com/duo/website/issues/1506

We need to begin to start considering this since the gallery already needs to grow and get updated. At one point it will be nice to be able to search or filter. After DL migration is complete we should talk this one over and plan to make this happen.

here's where we left off with the filters for the gallery.

IBM_Gallery_filter_study_sb.zip

screen shot 2019-06-17 at 11 56 55 am

screen shot 2019-06-17 at 11 57 48 am

@alisonjoseph alisonjoseph transferred this issue from carbon-design-system/design-language-website Jul 11, 2019
@alisonjoseph alisonjoseph added this to the August 2019 milestone Jul 16, 2019
@alisonjoseph alisonjoseph removed this from the August 2019 milestone Sep 4, 2019
@jnm2377 jnm2377 self-assigned this Sep 12, 2019
@jnm2377
Copy link
Contributor

jnm2377 commented Sep 13, 2019

@jeanservaas @carbon-design-system/brand is there a sketch file for this? What is the expected UX for this? If I click a tag to select it, and then click it again does it de-select? Or can they only be de-selected through the refresh button? If there are categories selected, does the closed state look the same as when they're unselected? Asking because this is essentially a different variation of our filterable MulitiSelect and the unselected-closed state for that one looks different than the selected-closed state (there are tags that show you how many items you've selected).

@alisonjoseph
Copy link
Member Author

@jnm2377 I would reach out to @sadekbazaraa with questions. Might be worth scheduling a meeting to go over this to make sure we have specs/requirements that are dev-ready.

@sadekbazaraa
Copy link

Hi @jnm2377 — these are all great questions that you've asked above. These sketches were done a good while back to illustrate the concept. Long before Carbon components were more flushed out as they are to date. The sketch file is at the top of this thread.

We may have better solutions implemented for filtered searches at this point. @jeanservaas have you come across any examples along these lines?

@sadekbazaraa
Copy link

Just had a meeting with @jnm2377 and @jeanservaas. Next steps are for me to refine the design further and share back.

@jnm2377
Copy link
Contributor

jnm2377 commented Sep 30, 2019

@sadekbazaraa any updates on the design?

@sadekbazaraa
Copy link

Hi @jnm2377 — the design explorations got pushed further back in our backlog as suggested by @rw-us perhaps it can be resurrected next sprint.

FYI @mjabbink

@mjabbink
Copy link
Contributor

@sadek to pick back up for this quarter

@sadekbazaraa
Copy link

sadekbazaraa commented Jan 24, 2020

Yup, it's back on the radar. I had a meeting with Rohit, our new UX specialist to look at some of the details like the categories that we're considering and the details of the user flow so we can better pass off for development. The latest designs use a checkbox to filter with vs. tag clouds and should be more in sync with Carbon components.

FYI @mjabbink

@vpicone vpicone added status: needs design spec Development can't progress without a design spec and removed status: blocked 🙅‍♀️ labels Oct 10, 2020
@alisonjoseph
Copy link
Member Author

Going to close, please create a new issue if the gallery search and filter is still needed with design specs. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: needs design spec Development can't progress without a design spec type: enhancement 💡
Projects
None yet
Development

No branches or pull requests

6 participants