From 556484a7b32d5d972043375042e3408bbef57972 Mon Sep 17 00:00:00 2001 From: emyarod Date: Mon, 15 Mar 2021 11:22:38 -0500 Subject: [PATCH 1/2] refactor(NumberInput): remove unneeded aria-live and aria-atomic attrs --- packages/react/src/components/NumberInput/NumberInput.js | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/react/src/components/NumberInput/NumberInput.js b/packages/react/src/components/NumberInput/NumberInput.js index 2b0749fe8fae..015c0ce7bad5 100644 --- a/packages/react/src/components/NumberInput/NumberInput.js +++ b/packages/react/src/components/NumberInput/NumberInput.js @@ -468,9 +468,7 @@ class NumberInput extends Component { {...buttonProps} onClick={(evt) => this.handleArrowClick(evt, 'down')} title={decrementNumLabel || iconDescription} - aria-label={decrementNumLabel || iconDescription} - aria-live="polite" - aria-atomic="true"> + aria-label={decrementNumLabel || iconDescription}>
@@ -480,9 +478,7 @@ class NumberInput extends Component { {...buttonProps} onClick={(evt) => this.handleArrowClick(evt, 'up')} title={incrementNumLabel || iconDescription} - aria-label={incrementNumLabel || iconDescription} - aria-live="polite" - aria-atomic="true"> + aria-label={incrementNumLabel || iconDescription}>
From 9949d02032bdca1cdcca504886a8aba40f5fa6d6 Mon Sep 17 00:00:00 2001 From: emyarod Date: Mon, 15 Mar 2021 11:23:32 -0500 Subject: [PATCH 2/2] fix(NumberInput): set negative tabindex on number controls --- packages/react/src/components/NumberInput/NumberInput.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/packages/react/src/components/NumberInput/NumberInput.js b/packages/react/src/components/NumberInput/NumberInput.js index 015c0ce7bad5..91d39c10ba32 100644 --- a/packages/react/src/components/NumberInput/NumberInput.js +++ b/packages/react/src/components/NumberInput/NumberInput.js @@ -468,7 +468,8 @@ class NumberInput extends Component { {...buttonProps} onClick={(evt) => this.handleArrowClick(evt, 'down')} title={decrementNumLabel || iconDescription} - aria-label={decrementNumLabel || iconDescription}> + aria-label={decrementNumLabel || iconDescription} + tabIndex="-1">
@@ -478,7 +479,8 @@ class NumberInput extends Component { {...buttonProps} onClick={(evt) => this.handleArrowClick(evt, 'up')} title={incrementNumLabel || iconDescription} - aria-label={incrementNumLabel || iconDescription}> + aria-label={incrementNumLabel || iconDescription} + tabIndex="-1">