Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: OverflowMenu's onclick calls 2 times after each click #9744

Closed
2 tasks done
hungdev opened this issue Sep 27, 2021 · 2 comments · Fixed by #9816
Closed
2 tasks done

[Bug]: OverflowMenu's onclick calls 2 times after each click #9744

hungdev opened this issue Sep 27, 2021 · 2 comments · Fixed by #9816
Labels
component: overflow-menu package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@hungdev
Copy link

hungdev commented Sep 27, 2021

Package

carbon-components-react

Browser

Chrome

Package version

carbon component react v7.44.2

Description

OverflowMenu's onclick calls 2 times after each click, sometime it calls once, sometime it calls twice.

CodeSandbox example

https://codesandbox.io/s/fancy-sun-ewd48?file=/src/App.js:361-373

Steps to reproduce

Only click to OverflowMenu

Code of Conduct
@tay1orjones tay1orjones mentioned this issue Oct 4, 2021
Closed
57 tasks
@rzhekova
Copy link
Contributor

rzhekova commented Oct 5, 2021

Hello, I think I may have a solution to this issue. I can push up the changes if you don't mind assigning this to me. Thanks!

@jnm2377
Copy link
Contributor

jnm2377 commented Oct 6, 2021

@rzhekova feel free to open a PR and just comment that it closes this issue in the body. We'll review it. 😄

@rzhekova rzhekova mentioned this issue Oct 6, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: overflow-menu package: react carbon-components-react severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(OverflowMenu): add stopPropagation call to handleClick method rzhekova/carbon
4 participants
@joshblack @hungdev @jnm2377 @rzhekova