Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support non-english locales for default strings - g11n/i18n #9474

Closed
jnm2377 opened this issue Aug 12, 2021 Discussed in #8729 · 1 comment
Closed

Support non-english locales for default strings - g11n/i18n #9474

jnm2377 opened this issue Aug 12, 2021 Discussed in #8729 · 1 comment
Labels
component: tile needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡

Comments

@jnm2377
Copy link
Contributor

jnm2377 commented Aug 12, 2021

Discussed in #8729

Originally posted by hermansb May 20, 2021
Default strings such as Expand/Collapse here do not support a locale property in order to use languages other than English as a default string.

It is possible to pass in your own translated strings to override the English default via the tileCollapsedIconText and tileExpandedIconText properties [for the react components anyway] and for those that want to keep the defaults, they can pass in localized versions of the defaults in this way.

However, for those consumers in this position it would be most convenient to just have the default strings also provide defaults for the standard locales.

@jnm2377 jnm2377 added the proposal: open This request has gone through triaging. We're determining whether we take this on or not. label Feb 2, 2022
@jnm2377 jnm2377 added proposal: accepted This request has gone through triaging and we are accepting PR's against it. and removed proposal: open This request has gone through triaging. We're determining whether we take this on or not. labels Mar 21, 2022
@jnm2377 jnm2377 moved this to ⏱ Backlog in Design System Mar 21, 2022
@tay1orjones tay1orjones moved this to Accepted in Roadmap Aug 24, 2022
@sstrubberg sstrubberg added the needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. label Sep 16, 2022
@sstrubberg sstrubberg moved this from ⏱ Backlog to 🥶 Ice Box in Design System Sep 16, 2022
@sstrubberg sstrubberg moved this from Accepted to Accepted as community contribution in Roadmap Sep 16, 2022
@tay1orjones
Copy link
Member

At this time we're not going to pursue providing locale-level configuration of default string props.

The intent would be to override the default props with the translated strings

Repository owner moved this from 🥶 Ice Box to ✅ Done in Design System Nov 30, 2022
Repository owner moved this from Accepted as community contribution to Not pursuing in Roadmap Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tile needs: community contribution Due to roadmap and resource availability, we are looking for outside contributions on this issue. proposal: accepted This request has gone through triaging and we are accepting PR's against it. role: dev 🤖 type: enhancement 💡
Projects
Archived in project
Archived in project
Development

No branches or pull requests

3 participants