Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[icons] connect icon color to idl v2 library #8127

Closed
Tracked by #8870
laurenmrice opened this issue Mar 18, 2021 · 0 comments
Closed
Tracked by #8870

[icons] connect icon color to idl v2 library #8127

laurenmrice opened this issue Mar 18, 2021 · 0 comments
Labels
package: sketch @carbon/sketch role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@laurenmrice
Copy link
Member

laurenmrice commented Mar 18, 2021

As-is

  • The icon libraries each have their own copy of layer styles of the IDL color palette.
  • When the icons are generated into Sketch from the plugin sync, they are connected to the black layer style in the icon library color palette (the copy of the IDL color palette).

Screen Shot 2021-03-18 at 4 23 11 PM


To-be

  • The icon libraries should not have their own layer styles. We need to delete them.
  • When the icons are generated into Sketch from the plugin sync, they need to be connected to the black layer style from the IBM Design Language v2 library. You can download the library at Step 3 here. https://www.carbondesignsystem.com/designing/kits/sketch/#get-the-kit

Screen Shot 2021-03-18 at 4 25 29 PM


*Note

  • For inner fills: The plugin is currently doing this correctly and we just need to make sure that is carried over when we use the idl v2 black layer style.
  • Inner fills are connected to the blacklayer style, but the opacity is set to 0%.

Screen Shot 2021-03-18 at 4 31 37 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: sketch @carbon/sketch role: dev 🤖 severity: 4 https://ibm.biz/carbon-severity type: bug 🐛
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants